GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Backport PR #31282 on branch v3.10.x (SEC: Block shell escapes in latex and ps commands) by ksunden · Pull Request #31545 · matplotlib/matplotlib

Conversation

@ksunden

@ksunden ksunden commented Apr 21, 2026

Copy link
Copy Markdown
Member

SEC: Block shell escapes in latex and ps commands
(cherry picked from commit 8ff895d)

The test that was edited had significant updates on main, so the old
test was kept on backport and no similar call exists in the old test.

PR summary

PR checklist

  • "closes #0000" is in the body of the PR description to link the related issue
  • new and changed code is tested
  • Plotting related features are demonstrated in an example
  • New Features and API Changes are noted with a directive and release note
  • Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WeatherGod @ksunden
Merge pull request matplotlib#31282 from scottshambaugh/tex_no_shell
acc6024 
SEC: Block shell escapes in latex and ps commands
(cherry picked from commit 8ff895d)

The test that was edited had significant updates on main, so the old
test was kept on backport and no similar call exists in the old test.
@github-actions github-actions Bot added backend: pgf backend: ps labels Apr 21, 2026
@ksunden

ksunden commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

Notably on this one, the test which was changed by the PR was totally rewritten on main and so did not see an update on this backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ksunden

ksunden commented Apr 21, 2026

Copy link
Copy Markdown
Member Author

I do not care to fix the linting error, it was introduced by a recently merged backport and passes our linting on main, so more trouble than it is worth to clear that, in my opinion. (I'll admit, I merged the backport which introduced it thinking the lint checks were scoped to changes...)
timhoffm reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
timhoffm
timhoffm approved these changes Apr 22, 2026
View reviewed changes
@timhoffm

timhoffm commented Apr 22, 2026

Copy link
Copy Markdown
Member

Doc build failure comes also from another backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@timhoffm
timhoffm merged commit a4f57ab into matplotlib:v3.10.x Apr 22, 2026
33 of 38 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic QuLogic added this to the v3.10.9 milestone Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

backend: pgf backend: ps

Projects

None yet

Milestone

v3.10.9

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ksunden @timhoffm @QuLogic @WeatherGod
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.