GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Bugfix/legend windowcall by WeatherGod · Pull Request #32 · matplotlib/matplotlib

Conversation

@WeatherGod

@WeatherGod WeatherGod commented Mar 7, 2011

Copy link
Copy Markdown
Member

Fix the legend object's get_window_extent() call signature to match everyone else's get_window_extent() call signature. This will allow for legend() to be passed into bbox_extra_artists kwarg for savefig().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WeatherGod
Make the Legend object's get_window_extent()'s call signature consist…
314a095 
…ent with everyone else's get_window_extent()'s call signature.
@mdboom

mdboom commented Mar 7, 2011

Copy link
Copy Markdown
Member

Looks good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WeatherGod

WeatherGod commented Mar 7, 2011

Copy link
Copy Markdown
Member Author

Ok, so how do I do this properly? I haven't tried doing a merge into v1.0.x and then into master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom

mdboom commented Mar 7, 2011

Copy link
Copy Markdown
Member

Not sure. I think Darren should know (and there are plans to add these instructions to the developer docs eventually)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Mar 7, 2011

Copy link
Copy Markdown
Member

First make sure your v1.0.x branch is fresh:

git checkout v1.0.x
git pull --ff-only upstream v1.0.x

(This assumes an "upstream" remote pointing to git://github.com/matplotlib/matplotlib.git.) Then merge your pull request and run the test suite (I don't know if this should be mandatory):

git merge bugfix/legend_windowcall
python setup.py install # or however you compile things to run the tests
./tests.py # all new test runner script!

If everything is fine, push:

git push [email protected]:matplotlib/matplotlib.git v1.0.x

Next do the same with master, this time merging v1.0.x:

git checkout master
git pull --ff-only upstream master
git merge v1.0.x
python setup.py install
./tests.py
git push [email protected]:matplotlib/matplotlib.git master

I'll post these instructions on the developer list so people can comment on them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richbwood richbwood mentioned this pull request Dec 19, 2012
test_pcolormesh hangs #1609
Closed
@WeatherGod
WeatherGod deleted the bugfix/legend_windowcall branch July 23, 2014 12:55
@WeatherGod WeatherGod mentioned this pull request Mar 2, 2018
pyplot hangs at plot() #10648
Closed
@InCogNiTo124 InCogNiTo124 mentioned this pull request Mar 15, 2020
Qt5 navigatonaltoolbar goes wild when vertical #16777
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@WeatherGod @mdboom @jkseppan
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.