GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — ENH: Add paragraph direction to FT2Font layout by msarmadsohail · Pull Request #32563 · matplotlib/matplotlib ConversationPR summaryPart of #32511. Matplotlib never tells libraqm the paragraph direction, so libraqm guesses it from the first This PR does the low-level part we agreed on in the issue:
The new test AI DisclosureI used Claude to explain the relevant code to me.
PR quality check
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsAdd an ft2font.Direction enum and a direction argument to FT2Font.set_text and _layout, passed on to raqm_set_par_direction. Without it, right-to-left text that starts with a Latin word is laid out left-to-right, e.g. an Urdu or Arabic sentence that opens with an English name ends up with its words and punctuation in the wrong order. Direction is also part of the layout cache key, so cached results are not reused across directions. See matplotlib#32511.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |