GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Cleanup test_transforms by iccir · Pull Request #32567 · matplotlib/matplotlib

Conversation

@iccir

@iccir iccir commented Nov 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR summary

This PR includes the test case changes discussed in #32547:

  • Adds TestAffine2D._check_transform to run a transform on a point or sequence of points. In the 1D case, this method converts to a numpy array and tests the 2D equivalent in C++.
  • The values of TestAffine2D.single_point, TestAffine2D.multiple_points, TestAffine2D.pivot are now explicitly written out at the call site.
  • test_translate_plus_other() performs an exact comparison for the translate+scale case.

In addition:

  • Instead of hard-coding 26.5650512, 14.0362435 everywhere, I added a new _atan function to return the arctangent in degrees. This exposed a floating point rounding issue on arm64 in test_translate_plus_other(), so I had to change the assert_array_equal to assert_array_almost_equal.

AI Disclosure

None used.

PR quality check

  • Use an expressive title, e.g. "Fix title font property precedence"
  • New and changed code is tested
  • [/] Plotting related features are demonstrated in an example
  • [/] New features and API changes have release notes
  • [/] Documentation complies with general and docstring guidelines

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@iccir iccir added the status: waiting for other PR label Nov 2, 2026
@github-actions github-actions Bot added topic: path handling topic: transforms and scales labels Nov 2, 2026
@iccir iccir added topic: testing and removed topic: path handling labels Nov 2, 2026
@github-actions github-actions Bot added the topic: path handling label Nov 2, 2026
@iccir
Cleanup test_transforms
4eb5a55
@iccir
iccir force-pushed the affine-test-cleanup branch from 5fb649b to 4eb5a55 Compare November 3, 2026 02:45
@github-actions github-actions Bot removed topic: path handling topic: transforms and scales labels Nov 3, 2026
@iccir iccir removed the status: waiting for other PR label Nov 3, 2026
@iccir
iccir marked this pull request as ready for review November 3, 2026 03:06
@iccir
iccir requested a review from timhoffm November 3, 2026 03:24
timhoffm
timhoffm approved these changes Nov 3, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timhoffm timhoffm timhoffm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic: testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@iccir @timhoffm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.