GeezerVison is showing github.com — Cleanup test_transforms by iccir · Pull Request #32567 · matplotlib/matplotlib
Conversation
iccir
commented
Nov 2, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR summary
This PR includes the test case changes discussed in #32547:
- Adds
TestAffine2D._check_transform to run a transform on a point or sequence of points. In the 1D case, this method converts to a numpy array and tests the 2D equivalent in C++.
- The values of
TestAffine2D.single_point, TestAffine2D.multiple_points, TestAffine2D.pivot are now explicitly written out at the call site.
test_translate_plus_other() performs an exact comparison for the translate+scale case.
In addition:
- Instead of hard-coding
26.5650512, 14.0362435 everywhere, I added a new _atan function to return the arctangent in degrees. This exposed a floating point rounding issue on arm64 in test_translate_plus_other(), so I had to change the assert_array_equal to assert_array_almost_equal.
AI Disclosure
None used.
PR quality check
- Use an expressive title, e.g. "Fix title font property precedence"
- New and changed code is tested
- [/] Plotting related features are demonstrated in an example
- [/] New features and API changes have release notes
- [/] Documentation complies with general and docstring guidelines
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Reviewers
timhoffm
timhoffm approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.