GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Introduce `mpl` buffer functions to replace `def_buffer()` by iccir · Pull Request #32576 · matplotlib/matplotlib Conversation
Contributor
PR summaryImportant This PR depends on #32532 and will appear larger than it really is until #32532 is merged. To view the actual changes in this PR, compare pybind-mplarray-initial → pybind-mplbuffer. This PR replaces our use of pybind11's For now, these functions will live in "py_buffer.h". In a future PR, there will be a variant that uses nanobind API and lives in some variant of: "mplutils.h", "mpl_buffer.h", or "mplbuffer.h". Both variants can exist as we adopt nanobind. UsageReplace The wrapped class needs to implement a // FT2Image::create_buffer_info auto *create_buffer_info() const { using BufferInfo = mpl::buffer_info<uint8_t, mpl::shape<-1, -1>>; return new BufferInfo(m_buffer, m_height, m_width); } Use // FT2Font::create_buffer_info auto *create_buffer_info() const { using BufferInfo = mpl::buffer_info<uint8_t, mpl::shape<-1, -1>>; auto result = new BufferInfo(image.data(), image.shape(0), image.shape(1)); result->set_owner(image.pyarray().ptr()); return result; } AI Disclosure
PR quality check
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…pybind-mplarray-initial This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |