GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Make set_yscale("log") consistent with semilogy() by dstansby · Pull Request #8537 · matplotlib/matplotlib

Conversation

@dstansby

@dstansby dstansby commented Apr 26, 2017

Copy link
Copy Markdown
Member

This is an update of #8056, which fixes #8045 - I have now added the new test image, which should make the tests pass. Thanks to @jcalbert for the original fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
emmyzero and others added 2 commits April 25, 2017 19:51
@emmyzero @dstansby
Fixed Axes.set_yscale and Axes.set_xscale so it has the same default
0b18f8f
 clipping behavior as plt.semilogy(), plt.semilogx() plt.loglog()
when handing non-positive data.
@dstansby
Update log scales test image
8c27e99
@dstansby dstansby added this to the 2.0.1 (next bug fix release) milestone Apr 26, 2017
@phobson

phobson commented Apr 26, 2017

Copy link
Copy Markdown
Member

If you remove the re-generated image, does it pass? (I can't spot the differences in the github UI)

          ImageComparisonFailure: images not close (RMS 0.044):
          	result_images/test_axes/log_scales_svg.png
          	result_images/test_axes/log_scales-expected_svg.png
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby

dstansby commented Apr 26, 2017

Copy link
Copy Markdown
Member Author

It seems to be the svg image (not the png one, which I updated) which is failing.

It's not failing locally on my OSX machine, and isn't failing on the OSX build either, so there must be a difference between linux and OSX when it comes to svg.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@phobson

phobson commented Apr 28, 2017

Copy link
Copy Markdown
Member

@dstansby maybe you need regenerate the SVG too.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby

dstansby commented Apr 28, 2017

Copy link
Copy Markdown
Member Author

It's not failing on my machine, so I have no way to regenerate it! I presume if a linux box regenerated it the OSX build would fail?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby dstansby added the status: needs revision label Apr 30, 2017
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.0.2 (next bug fix release) May 3, 2017
@dstansby

dstansby commented May 27, 2017

Copy link
Copy Markdown
Member Author

(note to myself to restart travis when #8672 gets merged)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anntzer

anntzer commented May 27, 2017

Copy link
Copy Markdown
Contributor

@dstansby done for you.

dstansby reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby

dstansby commented Jun 7, 2017

Copy link
Copy Markdown
Member Author

Restarting travis didn't move the build to 14.04, so manually cycling the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby dstansby closed this Jun 7, 2017
@dstansby dstansby reopened this Jun 7, 2017
@dstansby

dstansby commented Jun 8, 2017

Copy link
Copy Markdown
Member Author

Huh, still no luck on travis, will try and see what happens on a local linux box at some point.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anntzer anntzer mentioned this pull request Jun 20, 2017
hline at y=0 appears after setting yscale to log #8783
Closed
@tacaswell

tacaswell commented Jun 20, 2017

Copy link
Copy Markdown
Member

Can you check the history of why this was changed to clip? I have a vague memory that there was a long discussion at the time...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dstansby

dstansby commented Jun 21, 2017

Copy link
Copy Markdown
Member Author

It was originally changed to fix #163 (comment) - changing it back will break that problem, so I adding the code in that comment as a test would be a good idea.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tacaswell

tacaswell commented Jun 21, 2017

Copy link
Copy Markdown
Member

I do not see what changed about the test image...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@efiring

efiring commented Jun 23, 2017

Copy link
Copy Markdown
Member

I think the basic idea of this--essentially reverting #2147 and thereby restoring problematic errorbar behavior (#163)--will have to be noted, and we will have to be prepared for someone to raise the issue again. Overall I think it is an improvement, though.

I think that the errorbar problem could be fixed in the errorbar code in this way: for any errorbar covering a range from negative to positive values, insert a point in the Line2D at 1e-300. It would have no effect with a linear scale, and with a log scale it would allow a line to be plotted after the negative end-point is masked out. Worth the trouble? I'm not sure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tacaswell tacaswell modified the milestones: 2.1 (next point release), 2.0.3 (next bug fix release) Jun 25, 2017
@tacaswell tacaswell added the API: changes Changes to the public API, typically requiring deprecation. label Jun 25, 2017
@tacaswell

tacaswell commented Jun 25, 2017

Copy link
Copy Markdown
Member

I am in favor of:

  • reverting Make nonposy='clip' default for log scale y-axes #2147 (with an API changes documentation)
  • adding a note to the errorbar docstring that, by default, errorbars which go negative will be clipped on log scales
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anntzer anntzer mentioned this pull request Jul 3, 2017
fill_between incorrect with log y-axis and value 0 #8623
Closed
@dstansby dstansby mentioned this pull request Jul 3, 2017
Mask invalid values by default when setting log scale #8836
Merged
@dstansby dstansby added the status: duplicate label Jul 3, 2017
@dstansby dstansby closed this Jul 3, 2017
@dstansby
dstansby deleted the fix-logclip branch July 3, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

API: changes Changes to the public API, typically requiring deprecation. status: duplicate status: needs revision

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

setting yscale to log, after drawing a plot with values equal to zero, results in incorrect handling of zero values

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@dstansby @phobson @anntzer @tacaswell @efiring @QuLogic @emmyzero
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.