GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update for building matplotlib under Mac OS X 10.7 Lion and XCode > 4.2 · Pull Request #899 · matplotlib/matplotlib

Conversation

@ghost

@ghost ghost commented May 25, 2012

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
xiron
Update for building matplotlib under Mac OS X 10.7 Lion and XCode > 4.2
d7d69eb
@efiring

efiring commented May 26, 2012

Copy link
Copy Markdown
Member

Maybe we need to have more than one make.osx; I imagine quite a few people will still be building on older systems, so I don't think we want the older version of make.osx simply vanish. But we certainly do want to have a version that works on the latest.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@efiring efiring mentioned this pull request Jun 9, 2012
setupext.py incorrect for Mac OS X #168
Closed
pelson
pelson reviewed Jun 13, 2012
View reviewed changes
Comment thread make.osx

@pelson pelson Jun 13, 2012

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see, this has made the code more likely to fail. Currently PNGVERSION in this file is 1.5.4 but the 1.5.4 folder only exists in the older-releases folder

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pelson

pelson commented Jun 24, 2012

Copy link
Copy Markdown
Member

@XIRON: Did you try using the setup.py? I know the preferred method states to use the make file, but I have had some success with the regular build process (10.7 and latest xcode, with some homebrew extras).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkseppan

jkseppan commented Jul 2, 2012

Copy link
Copy Markdown
Member

I got building to work with homebrew on 10.6 without using make.osx at all, so we might not really need make.osx for user builds. I think it has been used to build the downloadable binaries to work on a wide variety of OS X versions, and that use is probably still valid.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WeatherGod

WeatherGod commented Jul 19, 2012

Copy link
Copy Markdown
Member

What is the status of this PR? Do we need more testers? I have access to a user with this combination of specs who could do a test if needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pelson

pelson commented Jul 19, 2012

Copy link
Copy Markdown
Member

I don't have confidence that this change works (see my inline code comment), and @jkseppan and myself are awaiting to hear if using setup.py would work instead of using the make.osx (it does for me, and I have 10.7 with xcode 4.3.3, with additional brew installations).

If there were a pause/hold button on pull requests, I would have it pressed for this PR.

@XIRON: Does setup.py work for you? Is there any additional motivation for changing make.osx?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WeatherGod

WeatherGod commented Jul 19, 2012

Copy link
Copy Markdown
Member

as an additional datapoint, the user I was referring to just yesterday built and installed matplotlib from the master branch just fine. I am pretty sure he is using homebrew as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pelson

pelson commented Aug 11, 2012

Copy link
Copy Markdown
Member

@XIRON: I'm closing this issue as I don't believe that the code can work anymore (the png library on the sourceforge site is no longer in that location). Additionally, it is currently best to build mpl via the standard setup.py`` so the need for themake.osx``` seems to be diminishing (perhaps it is still needed for some distribution builds?).

We can always re-open this issue if there are good reasons to do so. If you are unable to build for osx 10.7 feel free to get in touch via the users or devel mailing list and I would be happy to help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pelson pelson closed this Aug 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@efiring @pelson @jkseppan @WeatherGod
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.