GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — API: do not truncate svg size to integer points by tacaswell · Pull Request #9817 · matplotlib/matplotlib

Conversation

@tacaswell

@tacaswell tacaswell commented Nov 19, 2017

Copy link
Copy Markdown
Member

PR Summary

closes #9815

This will svgs slightly bigger.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tacaswell added 2 commits November 19, 2017 16:28
@tacaswell
API: do not truncate the total size of svg element to integers
f435941 
closes matplotlib#9815
@tacaswell
TST: updated sizes of svg baseline images to have use floats
f15c26b
@tacaswell tacaswell added this to the v2.2 milestone Nov 19, 2017
anntzer
anntzer approved these changes Nov 19, 2017
View reviewed changes

@anntzer anntzer left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional on tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dstansby
dstansby approved these changes Nov 19, 2017
View reviewed changes

@dstansby dstansby left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if/when tests pass

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anntzer

anntzer commented Nov 20, 2017

Copy link
Copy Markdown
Contributor

thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anntzer
anntzer merged commit 7ddc73a into matplotlib:master Nov 20, 2017
@tacaswell
tacaswell deleted the fix_svg_size branch November 20, 2017 02:29
@QuLogic QuLogic modified the milestones: needs sorting, v2.2.0 Feb 12, 2018
@tacaswell tacaswell mentioned this pull request Jul 9, 2022
Fixed SVG-as-text image comparison tests. #23350
Merged
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes
@dstansby dstansby dstansby approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.2.0

Development

Successfully merging this pull request may close these issues.

svg backend truncates output size to integer, which it doesn't need to (and pdf backend doesn't)

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tacaswell @anntzer @dstansby @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.