GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove inventory redirect by tacaswell · Pull Request #67 · matplotlib/matplotlib.github.com

Conversation

@tacaswell

@tacaswell tacaswell commented Mar 10, 2022

Copy link
Copy Markdown
Member

Per discussion in
matplotlib/matplotlib#22601 (comment)
this is actually breaking builds in subtle very brittle way as the links that
will be generated will be pointing at the top-level files (that are actually
re-directs to /stable).

The second step of this will be to put a 301 redirect into caddy.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tacaswell
Remove inventory redirect
3bda6bb 
Per discussion in
matplotlib/matplotlib#22601 (comment)
this is actually breaking builds in subtle very brittle way as the links that
will be generated will be pointing at the top-level files (that are actually
re-directs to /stable).

The second step of this will be to put a 301 redirect into caddy.
@QuLogic

QuLogic commented Mar 10, 2022

Copy link
Copy Markdown
Member

We're actually serving from main there, though we could switch to gh-pages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell
tacaswell changed the base branch from gh-pages to main March 10, 2022 22:52
@tacaswell

tacaswell commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

Changed the bass branch. From reading the ansible (~L95) where we do the checkouts all of the repos go to gh-pages so I thought we were doing gh-pages everywhere.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@QuLogic

QuLogic commented Mar 10, 2022

Copy link
Copy Markdown
Member

Yea, they're currently in sync, so I was a bit lazy with writing the Ansible, but that's not what's currently being served.
tacaswell reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell

tacaswell commented Mar 10, 2022

Copy link
Copy Markdown
Member Author

Given that the caddy configuration seems to be taking precedence anyway, this is a pretty low priority to get done (mostly to avoid confusing future us).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tacaswell
tacaswell changed the base branch from main to gh-pages April 18, 2022 15:07

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tacaswell @QuLogic
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.