GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ability to process metadata by AmirMehrabi · Pull Request #1 · matscode/paystack

Conversation

@AmirMehrabi

@AmirMehrabi AmirMehrabi commented Jul 24, 2024

Copy link
Copy Markdown
Contributor

Hello.

Great package. But I needed to add metadata to my requests. This pull request adds the ability to just do that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AmirMehrabi added 2 commits July 25, 2024 01:32
@AmirMehrabi
Add ability to process metadata in the requests
1193661
@AmirMehrabi
Update README.md to reflect the changes regarding setting metadata
d04bf1c
@matscode

matscode commented Jul 25, 2024

Copy link
Copy Markdown
Owner

Nice initiative @AmirMehrabi .

However, this package as moved to Paystack PHP SDK and I am guessing it has the ability to add metadata already.

I recommened you use the new package as it is the only one that would receive possible future update.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AmirMehrabi

AmirMehrabi commented Jul 25, 2024

Copy link
Copy Markdown
Contributor Author

Nice initiative @AmirMehrabi .

However, this package as moved to Paystack PHP SDK and I am guessing it has the ability to add metadata already.

I recommened you use the new package as it is the only one that would receive possible future update.

Hello,
I hope you're doing well.

I actually saw that package when I wanted to integrate paystack. But unfortunately, we're still on legacy code and for those of us who are still using old versions of Laravel, that "Paystack PHP SDK" package has unresolvabale dependencies so we can't use it.

But this one is still usable for old versions of laravel. That's why I used this one instead. And there are probably people like me out there, so merging this PR would help them as well.

Thank you,
Regards
matscode reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
matscode
matscode requested changes Jul 25, 2024
View reviewed changes
Comment thread src/Transaction.php Resolved

Uh oh!

There was an error while loading. Please reload this page.
@matscode

matscode commented Jul 25, 2024

Copy link
Copy Markdown
Owner

Nice initiative @AmirMehrabi .
However, this package as moved to Paystack PHP SDK and I am guessing it has the ability to add metadata already.
I recommened you use the new package as it is the only one that would receive possible future update.

Hello, I hope you're doing well.

I actually saw that package when I wanted to integrate paystack. But unfortunately, we're still on legacy code and for those of us who are still using old versions of Laravel, that "Paystack PHP SDK" package has unresolvabale dependencies so we can't use it.

But this one is still usable for old versions of laravel. That's why I used this one instead. And there are probably people like me out there, so merging this PR would help them as well.

Thank you, Regards

I see your point... 🤚🏽
AmirMehrabi reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AmirMehrabi
Removing the type from method input
656871c
matscode
matscode approved these changes Jul 25, 2024
View reviewed changes
@matscode
matscode merged commit 2c03c1a into matscode:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matscode matscode matscode approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AmirMehrabi @matscode
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.