Description

Christof Marti (chrmarti)

opened on Mar 17, 2016

Issue body actions

TypeScript Version:

1.8.2 (Playground on 20160317)

Code

module Some {
    export const thing = "";
}

Expected behavior:

Should compile to:

var Some;
(function (Some) {
    var thing = "";
    Some.thing = thing;
})(Some || (Some = {}));

So internal references can use the local variable which will minify well. Exported functions and classes already compile minifier-friendly.

Actual behavior:

But compiles to:

var Some;
(function (Some) {
    Some.thing = "";
})(Some || (Some = {}));

So internal references use the nested reference which does not minify.

Activity

1. mhegazy commented on Mar 17, 2016

   

   Mohamed Hegazy (mhegazy)

   on Mar 17, 2016

   Contributor

   More actions

   now every other reference to thing needs to be Some.thing. this not only impacts minification, it also impacts performance.

   I expect what you want is constant folding and propagation, see #3964
2. Mohamed Hegazy (mhegazy)

   closed this as completedon Mar 17, 2016
3. Mohamed Hegazy (mhegazy)

   added

   DuplicateAn existing issue was already createdAn existing issue was already created

   on Mar 17, 2016
4. chrmarti commented on Mar 17, 2016

   

   Christof Marti (chrmarti)

   on Mar 17, 2016

   Author

   More actions

   This is different from what I understand. I specifically want to avoid const values being inlined because that that makes the resulting code larger. The goal is to have code that can be shrunk better by a minifier for JavaScript.

   To compare a few examples:

   module Some {
       export const thing = "";
       export function getThing() {
           return thing;
       }
       getThing();
       export class Thing {}
       var t = new Thing();
   }

   This compiles to:

   var Some;
   (function (Some) {
       Some.thing = "";
       function getThing() {
           return Some.thing;
       }
       Some.getThing = getThing;
       getThing();
       var Thing = (function () {
           function Thing() {
           }
           return Thing;
       }());
       Some.Thing = Thing;
       var t = new Thing();
   })(Some || (Some = {}));

   A JavaScript minfier will rename function getThing and the two direct references to some short name. Likewise with the class Thing and its two direct references. With the exported const though, it cannot do that, because that is not assigned to a local variable.

   The request here is to have a local variable for the exported const to which the value is assigned and which is then referenced everywhere from within the local scope.
5. Ryan Cavanaugh (RyanCavanaugh)

   removed

   DuplicateAn existing issue was already createdAn existing issue was already created

   on Mar 17, 2016
6. Ryan Cavanaugh (RyanCavanaugh)

   reopened this on Mar 17, 2016
7. Mohamed Hegazy (mhegazy)

   added

   SuggestionAn idea for TypeScriptAn idea for TypeScript

   In DiscussionNot yet reached consensusNot yet reached consensus

   on Jun 2, 2016
8. Ryan Cavanaugh (RyanCavanaugh)

   added

   Accepting PRs

   and removed

   In DiscussionNot yet reached consensusNot yet reached consensus

   on Jun 9, 2016
9. RyanCavanaugh commented on Jun 9, 2016

   

   Ryan Cavanaugh (RyanCavanaugh)

   on Jun 9, 2016

   Member

   More actions

   Approved but please wait for the new transforms-based emitter to merge before sending a PR
10. Mohamed Hegazy (mhegazy)

    added this to the This milestone has been deleted milestone on Jun 9, 2016
11. pjordaan commented on Jan 6, 2017

    

    Pieter Jordaan (pjordaan)

    on Jan 6, 2017

    More actions

    most people use uglify.js for minification.
    If i read the documentations of uglify.js I can define a const with the const keyword in a javascript file and make uglify.js remove dead code/optimize the constant. However uglify.js will only output const keyword in ES6 code, which uglify.js can't parse. If I output it to ES5 code it becomes a regular var variable and uglify.js can't optimize it better. Would be nice to have an option to force the use of the const keyword in ES5 output, or prefix the var statement with the comment /** @const */

    Doing something like that would make the code better minifiable in all cases.

    Reacted by Aluan Haddad
12. Ryan Cavanaugh (RyanCavanaugh)

    modified the milestones: Community, Backlog on Mar 7, 2019
13. RyanCavanaugh commented on Mar 4, 2024

    

    Ryan Cavanaugh (RyanCavanaugh)

    on Mar 4, 2024

    Member

    More actions

    No one seemed interested in sending a PR for this and very few people are using value-based namespace anymore
14. Ryan Cavanaugh (RyanCavanaugh)

    closed this as not plannedon Mar 4, 2024

Issue actions