GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Give correct info for contextually typed this by sandersn · Pull Request #11600 · microsoft/TypeScript

Conversation

@sandersn

@sandersn Nathan Shively-Sanders (sandersn) commented Oct 13, 2016

Copy link
Copy Markdown
Member

Fixes #10972

This essentially undoes #9746, which only contextually typed object literal methods, but did so early, during getSignatureFromDeclaration. The compiler now contextually types everything, as it did before, but only looks for a contextual type if there is no declared this type.

After #9746, a member list request from the language service would call getSignatureFromDeclaration, but it would never get a contextual this-type, because contextual typing was only enabled for object literal methods.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aluanhaddad reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sandersn
Give correct info for contextually typed this
853607f
This essentially undoes #9746, which only contextually typed object
literal methods, but did so early, during `getSignatureFromDeclaration`.
The compiler now contextually types everything, as it did before, but
only looks for a contextual type if there is no declared `this` type.

After #9746, a member list request from the language service would call
`getSignatureFromDeclaration`, but it would never get a contextual this-type,
because contextual typing was only enabled for object literal methods.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Oct 13, 2016
This was referenced Oct 17, 2016
Fix #4241, infer partially annotated function #11529
Closed
Contextual typing of partially annotated signatures #11673
Merged
@mhegazy

Mohamed Hegazy (mhegazy) commented Oct 18, 2016

Copy link
Copy Markdown
Contributor

closing in favor of #11673

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mhegazy Mohamed Hegazy (mhegazy) closed this Oct 18, 2016
@mhegazy
Mohamed Hegazy (mhegazy) deleted the fix-contextual-this-in-function-expressions branch November 2, 2017 21:03
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sandersn @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.