GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Disable evolving types with implicit any by sandersn · Pull Request #12362 · microsoft/TypeScript

Conversation

@sandersn

@sandersn Nathan Shively-Sanders (sandersn) commented Nov 18, 2016

Copy link
Copy Markdown
Member

Fixes #11839

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Nathan Shively-Sanders (sandersn) added 2 commits November 18, 2016 13:51
@sandersn
Disable evolving types with implicit any
8674d92 
That is, without --noImplicitAny
@sandersn
Update baselines to have no evolving types
a4d584f
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 18, 2016
@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 18, 2016

Copy link
Copy Markdown
Member Author

Mohamed Hegazy (@mhegazy) Anders Hejlsberg (@ahejlsberg) I disabled evolving types when --noImplicitAny isn't on.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Always enable evolving types in Javascript files
7750fe1
@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 18, 2016

Copy link
Copy Markdown
Member Author

Mohamed Hegazy (@mhegazy) thanks for the reminder to always leave evolving types on for Javascript files.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Nov 18, 2016
View reviewed changes
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

We will need to port this to release-2.1 as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Nathan Shively-Sanders (sandersn) merged commit b514d7c into master Nov 18, 2016
@sandersn
Nathan Shively-Sanders (sandersn) deleted the disable-evolving-types-with-implicit-any branch November 18, 2016 23:39
@sandersn

Nathan Shively-Sanders (sandersn) commented Nov 18, 2016

Copy link
Copy Markdown
Member Author

Done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Nov 20, 2016
Introduce 'getTypeOfExpression' function #12396
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sandersn @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.