GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixes for #12291 and #12326: Declaration emit when there are errors in the source file by sheetalkamat · Pull Request #12363 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Nov 18, 2016

Copy link
Copy Markdown
Member
  • Handle the scenario when heritage clause of interface is not entity name expression
    Fixes Compiler crashes when emitting declaration for malformed interface  #12291
  • Handle when type alias's type parameter extends type that wont get emitted in .d.ts
    Fixes Debug Failure when emitting declaration for unresolved type constraints #12326

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
HerringtonDarkholme reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sheetal Nandi (sheetalkamat) added 2 commits November 18, 2016 13:11
@sheetalkamat
Handle the scenario when heritage clause of interface is not entity n…
cbde25f 
…ame expression

Fixes #12291
@sheetalkamat
Handle when type alias's type parameter extends type that wont get em…
aa55650 
…itted in .d.ts

Fixes #12326
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Nov 18, 2016
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

👍
we should disable emitting declaration files if there are errors.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit f626ff7 into master Nov 18, 2016
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the declarationsInFilesWithErrors branch November 18, 2016 22:57
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.