GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Clean up for ES2015 transforms by rbuckton · Pull Request #13040 · microsoft/TypeScript

Conversation

@rbuckton

@rbuckton Ron Buckton (rbuckton) commented Dec 20, 2016 •
edited by DanielRosenwasser
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR isolates the cleanup work in the es2015 transform that is also found in #12783.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Ron Buckton (rbuckton) added 3 commits December 8, 2016 15:30
@rbuckton
Simplify es2015 visitor, replace function tracking with flags
25c7caa
@rbuckton
Merge branch 'master' into es2015-cleanup
4f863e8
@rbuckton
Improve hierarchy fact tracking
fa53eb1
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Dec 20, 2016
@rbuckton
Ron Buckton (rbuckton) requested review from Daniel Rosenwasser (DanielRosenwasser), Mohamed Hegazy (mhegazy) and Vladimir Matveev (vladima) December 20, 2016 01:24
vladima
Vladimir Matveev (vladima) approved these changes Dec 23, 2016
View reviewed changes
@rbuckton
Ron Buckton (rbuckton) merged commit e90742f into master Dec 23, 2016
@rbuckton
Ron Buckton (rbuckton) deleted the es2015-cleanup branch December 23, 2016 00:31
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
@mhegazy Mohamed Hegazy (mhegazy) Awaiting requested review from mhegazy
1 more reviewer
@vladima Vladimir Matveev (vladima) vladima approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rbuckton @vladima @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.