GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert #15104 by mhegazy · Pull Request #15381 · microsoft/TypeScript

Conversation

@mhegazy

@mhegazy Mohamed Hegazy (mhegazy) commented Apr 25, 2017

Copy link
Copy Markdown
Contributor

Reverts #15104 for release-2.3

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mohamed Hegazy (mhegazy) added 9 commits April 25, 2017 14:46
@mhegazy
Revert "Update tests"
22647bb 
This reverts commit 3cda0ea.
@mhegazy
Revert "Allow callbacks unioned with null and/or undefined"
e86512e 
This reverts commit ec35b80.
@mhegazy
Revert "Add another test case"
cf17be2 
This reverts commit 510bc81.
@mhegazy
Revert "Accept new baselines"
d581bed 
This reverts commit 33bc9d1.
@mhegazy
Revert "Check callback return values bi-variantly"
42d6a9c 
This reverts commit 189fc51.
@mhegazy
Revert "Add tests"
3abd0c8 
This reverts commit 50f84b1.
@mhegazy
Revert "Accept new baselines"
70bb2d3 
This reverts commit 11543d7.
@mhegazy
Revert "Fix callback types to match covariantly"
96a3c91 
This reverts commit eebd67f.
@mhegazy
Revert "Treat callback parameters as strictly covariant"
fe0a307 
This reverts commit 8ae3e05.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Apr 25, 2017
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 25, 2017

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 9ada915 into release-2.3 Apr 25, 2017
@mhegazy
Mohamed Hegazy (mhegazy) deleted the revert15104 branch April 25, 2017 22:18
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mhegazy @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.