GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Check applicable signature fix by gcnew · Pull Request #16104 · microsoft/TypeScript

Conversation

@gcnew

@gcnew Marin Marinov (gcnew) commented May 26, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use parameter inference when checking whether the provided arguments are applicable on the (inferred) signature.

Fixes #3410, #14766, #16107

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-already-signed label May 26, 2017
Marin Marinov (gcnew) added 7 commits May 26, 2017 21:16
@gcnew
Fixed check applicable signature to use actual inferrence
2063fa1
@gcnew
Use a single fakeInferenceChecker
de2b6d0
@gcnew
Baseline accept
ff145a7
@gcnew
Added a comment explaining the change in `instantiateSignatureInConte…
e0c876e 
…xtOf`
@gcnew
Fixed lint errors
40e25c6
@gcnew
Fixed fourslash tests
24f2945
@gcnew
Fixed rebase errors
69b2e7c
@gcnew
Marin Marinov (gcnew) force-pushed the checkApplicableSignatureFix branch from 93e0e7d to 69b2e7c Compare May 26, 2017 18:41
@gcnew Marin Marinov (gcnew) mentioned this pull request May 26, 2017
Unexpected behavior of generic constraints #3410
Closed
Marin Marinov (gcnew) added 3 commits May 27, 2017 06:11
@gcnew
Use return type as inference location
655ffac
@gcnew
Added tests with programmer provided unions
6b99a06
@gcnew
Baseline accept
144a018
@gcnew
Marin Marinov (gcnew) force-pushed the checkApplicableSignatureFix branch from ee05467 to 144a018 Compare May 27, 2017 03:12
@gcnew Marin Marinov (gcnew) mentioned this pull request Jun 6, 2017
question: how can i create and return a generic function in TypeScript? #9949
Closed
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Jun 8, 2017

Copy link
Copy Markdown
Member

I think the issues fixed by this PR are now covered in a more general way by #16368.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gcnew

Marin Marinov (gcnew) commented Jun 9, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Yes, indeed. #16368 fixes the instantiation/type constraints issues in a more general way.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gcnew

Marin Marinov (gcnew) commented Jun 9, 2017

Copy link
Copy Markdown
Contributor Author

Closing this on in favour of #16368.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gcnew Marin Marinov (gcnew) closed this Jun 9, 2017
@gcnew Marin Marinov (gcnew) mentioned this pull request Jun 11, 2017
Simplify generic function call error reporting #16439
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gcnew @ahejlsberg @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.