GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — allow empty tuple, fixes #13126 by KiaraGrouwstra · Pull Request #17762 · microsoft/TypeScript

Conversation

@KiaraGrouwstra

@KiaraGrouwstra kiara (KiaraGrouwstra) commented Aug 13, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #13126 / #13239.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@KiaraGrouwstra
ditch empty tuple check
665f44f
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Aug 13, 2017

Copy link
Copy Markdown

@tycho01,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-signed label Aug 13, 2017
@KiaraGrouwstra

kiara (KiaraGrouwstra) commented Aug 13, 2017

Copy link
Copy Markdown
Contributor Author

I apologize, it appears there was a similar effort at #14646. I suppose perhaps I could leave this for reference until either gets merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zpdDG4gta8XKpMCd

ZpdDG4gta (zpdDG4gta8XKpMCd) commented Aug 13, 2017 via email

Copy link
Copy Markdown
#14646 <#14646> looks abandoned
…
On Sun, Aug 13, 2017 at 5:14 AM, Tycho Grouwstra ***@***.***> wrote: I apologize, it appears there was a similar effort at #14646 <#14646>. I suppose perhaps I could leave this for reference until either gets merged. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17762 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5PzflCfxTTgAa1_92ik4JHrZTYbo8yks5sXr5vgaJpZM4O1okH> .
-- Aleksey Bykov
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KiaraGrouwstra
empty tuple tests all good
03bf0b8
@KiaraGrouwstra

kiara (KiaraGrouwstra) commented Aug 13, 2017

Copy link
Copy Markdown
Contributor Author

Aleksey-Bykov: Thanks. I've incorporated their progress to get this back on track.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KiaraGrouwstra kiara (KiaraGrouwstra) mentioned this pull request Aug 13, 2017
Make tuples have known length #17765
Merged
@KiaraGrouwstra kiara (KiaraGrouwstra) mentioned this pull request Aug 24, 2017
Add empty tuple type #14646
Closed
@KiaraGrouwstra

kiara (KiaraGrouwstra) commented Aug 27, 2017

Copy link
Copy Markdown
Contributor Author

#14646 seems back on track, so closing in favor of that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KiaraGrouwstra kiara (KiaraGrouwstra) closed this Aug 27, 2017
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@KiaraGrouwstra @msftclas @zpdDG4gta8XKpMCd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.