GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support find-all-references for `default` keyword · Pull Request #17992 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Aug 23, 2017

Copy link
Copy Markdown

Fixes #13662

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pitamar reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Aug 23, 2017
@ghost ghost mentioned this pull request Aug 23, 2017
Symbol display for export default should be "export default", not "import default" #17990
Closed
Andy Hanson
Support find-all-references for anonymous default exports
1fbd6d0
@ghost
ghost force-pushed the findAllRefsDefault branch from 76b1600 to 1fbd6d0 Compare August 23, 2017 22:10
Andy Hanson
Also handle re-exported default exports
abb1f3e
@ghost
ghost requested a review from Sheetal Nandi (sheetalkamat) August 29, 2017 14:54
Andy Hanson
Merge branch 'master' into findAllRefsDefault
ecbbd2a
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented Sep 5, 2017

Copy link
Copy Markdown
Member

Can you add test that covers default keyword presence/absence in search with allowSyntheticDefaultImports option
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andy Hanson
Add test for using export = with --allowSyntheticDefaultExports
5124891
@ghost
ghost force-pushed the findAllRefsDefault branch from a4614ed to 5124891 Compare September 6, 2017 16:59
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Sep 6, 2017
View reviewed changes
@ghost
ghost merged commit b3c87aa into master Sep 7, 2017
@ghost
ghost deleted the findAllRefsDefault branch September 7, 2017 14:26
@ghost ghost mentioned this pull request Sep 20, 2017
Find references does not work for re-exported default #17007
Closed
@ghost ghost mentioned this pull request Oct 18, 2017
findAllRefs: Support anonymous default export #19302
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) Awaiting requested review from sheetalkamat

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.