GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix checking of recursive callback types by ahejlsberg · Pull Request #19107 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Oct 11, 2017

Copy link
Copy Markdown
Member

This PR fixes the logic introduced in #15104 to only check for callback parameters when we aren't in a recursive call to compareSignaturesRelated that resulted from an outer callback check.

Fixes #18277.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Anders Hejlsberg (ahejlsberg) added 3 commits October 11, 2017 12:01
@ahejlsberg
Don't check for callbacks in recursive call that resulted from callbacks
81fc2a1
@ahejlsberg
Add regression test
07e4819
@ahejlsberg
Accept new baselines
38cec12
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Oct 11, 2017
Track recursive callback-covariance calls to compareSignaturesRelated #19078
Closed
@ahejlsberg

Anders Hejlsberg (ahejlsberg) commented Oct 11, 2017

Copy link
Copy Markdown
Member Author

This PR supercedes #19078.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ahejlsberg
Anders Hejlsberg (ahejlsberg) requested review from Mohamed Hegazy (mhegazy) and Nathan Shively-Sanders (sandersn) October 11, 2017 19:11
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Oct 11, 2017
View reviewed changes
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Oct 11, 2017
View reviewed changes
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit 6cf41ae into master Oct 11, 2017
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the fixRecursiveCallbacks branch October 11, 2017 23:28
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
+1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stack overflow while type checking generic, mutually-defined function interfaces

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ahejlsberg @sandersn @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.