GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — This fixes the issue with tsc --watch when module emit kind is none and directory watcher gets invoked instead of file by sheetalkamat · Pull Request #19263 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Oct 17, 2017

Copy link
Copy Markdown
Member

This handles the case when directory watcher is invoked instead of file watcher for the changes in the file.
This only needs handling tsc --watch callback since from tsserver side we don't do anything specific with file changed or when file added to the directory.
Also this is only issue when module emit kind is none = builder will use non emit handler which means that it wont do any extra checks if file versions have not changed hence not facing this issue otherwise.
Fixes #19206

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sheetal Nandi (sheetalkamat) added 2 commits October 17, 2017 14:13
@sheetalkamat
Handle when directory watcher is invoked on file change
a5861af 
Fixes #19206
@sheetalkamat
Merge branch 'master' into directoryWatcherInsteadOfFileWatch
bd0c210
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Oct 17, 2017
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit e99e933 into master Oct 17, 2017
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the directoryWatcherInsteadOfFileWatch branch October 17, 2017 22:08
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sheetalkamat @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.