GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix instanceof with type variable constrained to class by ahejlsberg · Pull Request #20142 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Nov 19, 2017

Copy link
Copy Markdown
Member

Fixes #20138.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Anders Hejlsberg (ahejlsberg) added 3 commits November 19, 2017 09:50
@ahejlsberg
Handle type variables in isTypeDerivedFrom
4057947
@ahejlsberg
Add tests
3d153e2
@ahejlsberg
Accept new baselines
06a9eb3
@ahejlsberg Anders Hejlsberg (ahejlsberg) mentioned this pull request Nov 19, 2017
instanceof type guard missing deduction #20138
Closed
@ahejlsberg
Anders Hejlsberg (ahejlsberg) requested a review from Mohamed Hegazy (mhegazy) November 20, 2017 17:32
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Nov 20, 2017
View reviewed changes
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit 005838f into master Nov 20, 2017
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the fixTypeVariableInstanceof branch November 20, 2017 20:57
@weswigham Wesley Wigham (weswigham) mentioned this pull request Nov 20, 2017
Fix build in the presence of definite assignment analysis #20170
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ahejlsberg @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.