GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Supports more locations for completions contextual types · Pull Request #21946 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Feb 14, 2018

Copy link
Copy Markdown

Supports more cases where we didn't get a contextual type before. As in #20020, adding this functionality to completions.ts instead of the checker, because e.g. the contextual type at a ( will only matter in completions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ghost
ghost requested a review from Armando Aguirre (armanio123) February 14, 2018 17:25
@ghost ghost changed the title Supports more types for recommended completions Supports more locations for completions contextual types Feb 14, 2018
@ghost
ghost force-pushed the completionsRecommended_contextualTypes branch from 9c561d2 to 9eb7461 Compare February 14, 2018 17:26
Andy Hanson
Supports more locations for completions contextual types
6f757a4
@ghost
ghost force-pushed the completionsRecommended_contextualTypes branch from 9eb7461 to 6f757a4 Compare February 14, 2018 17:43
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Feb 17, 2018
View reviewed changes
@ghost
ghost merged commit 69abe49 into master Feb 17, 2018
@ghost
ghost deleted the completionsRecommended_contextualTypes branch February 17, 2018 00:48
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@armanio123 Armando Aguirre (armanio123) Awaiting requested review from armanio123

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.