GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — isDeclarationName: support ComputedPropertyName · Pull Request #22123 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Feb 22, 2018

Copy link
Copy Markdown

As of #15473 we should be getting symbols on computed property names, so we might as well include those in our baselines.
Also note the symbolProperty24.errors.txt change, which required changing a symbol.escapedName use to symbolToString (#21009).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
isDeclarationName: support ComputedPropertyName
85a87ac
@ghost
ghost requested review from Ron Buckton (rbuckton) and Wesley Wigham (weswigham) February 22, 2018 18:23
@ghost
ghost force-pushed the computed_property_is_declaration_name branch from d15c75a to 85a87ac Compare February 22, 2018 18:23
@ghost
ghost requested a review from Nathan Shively-Sanders (sandersn) February 22, 2018 18:23
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Feb 22, 2018
View reviewed changes
Andy Hanson
update additional baseline
359e845
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Feb 22, 2018
View reviewed changes
@ghost
ghost merged commit a299d2d into master Feb 22, 2018
@ghost
ghost deleted the computed_property_is_declaration_name branch February 22, 2018 23:53
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 3, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rbuckton Ron Buckton (rbuckton) Awaiting requested review from rbuckton
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sandersn @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.