GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Lookup JSX namespace within factory function by weswigham · Pull Request #22207 · microsoft/TypeScript Conversation
|
|
Wesley Wigham (@weswigham) can you share perf numbers on one of our RWC jsx code bases comparing to before #21218, to #21218 + this change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| return getUnionType(map(instantiatedSignatures, getReturnTypeOfSignature), UnionReduction.Subtype); | ||
| } | ||
|
|
||
| function getJsxNamespaceForLocation(location: Node) { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Super nit, the naming of getJsxNamespaceForLocation should probably match getJsxStatelessElementTypeAt / getJsxElementClassTypeAt
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| */ | ||
| function getJsxIntrinsicTagNames(): Symbol[] { | ||
| const intrinsics = getJsxType(JsxNames.IntrinsicElements); | ||
| function getJsxIntrinsicTagNames(location: Node): Symbol[] { |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Similar, getJsxIntrinsicTagNamesAt
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Very nice |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| getAliasedSymbol(symbol: Symbol): Symbol; | ||
| getExportsOfModule(moduleSymbol: Symbol): Symbol[]; | ||
| getAllAttributesTypeFromJsxOpeningLikeElement(elementNode: JsxOpeningLikeElement): Type | undefined; | ||
| getJsxIntrinsicTagNames(): Symbol[]; |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
please add a note about this change in the breaking changes section in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Done. 👍
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.