GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Only make inferences from tuple types of right arity by ahejlsberg · Pull Request #22850 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Mar 24, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

With this PR we only make inferences between tuple types of matching arity. Since #17765 tuple types with different arity are known never to be assignment compatible, so there's no point in making inferences between them, and when the inference target is a union type it actually degrades the quality of inferences.

Fixes #22562.
Fixes #22563.
Fixes #22564.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
falsandtru reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Anders Hejlsberg (ahejlsberg) added 3 commits March 23, 2018 17:32
@ahejlsberg
Don't infer between tuple types with different arity
d6b6bb7
@ahejlsberg
Add regression tests
c2a53f9
@ahejlsberg
Accept new baselines
63f98de
@ahejlsberg
Anders Hejlsberg (ahejlsberg) requested review from Daniel Rosenwasser (DanielRosenwasser) and Nathan Shively-Sanders (sandersn) March 24, 2018 00:58
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Mar 26, 2018
View reviewed changes
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Mar 26, 2018
View reviewed changes
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit d7df84d into master Mar 26, 2018
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the tupleTypeInference branch March 26, 2018 16:35
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
+1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ahejlsberg @sandersn @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.