GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don't copy trivia when implementing an interface · Pull Request #23343 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Apr 11, 2018

Copy link
Copy Markdown

This was accidentally changed in #20338 to include the comments -- but we really shouldn't be copying the comments over from the base class.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Don't copy trivia when implementing an interface
072c51f
@ghost
ghost requested a review from Andrew Casey (amcasey) April 11, 2018 20:25
@ghost ghost mentioned this pull request Apr 11, 2018
Fix insertNodeAtClassStart for empty class with comment #23342
Merged
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Apr 11, 2018
View reviewed changes
amcasey
Andrew Casey (amcasey) approved these changes Apr 12, 2018
View reviewed changes
Comment thread src/services/utilities.ts Outdated
return visited;
}

export function getSynthesizedDeepCloneWithoutTrivia<T extends Node>(node: T): T {

@amcasey Andrew Casey (amcasey) Apr 12, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not pass an optional flag to getSynthesizedDeepClone?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Use an includeTrivia flag instead of a separate function
6a23c7d
@ghost
ghost merged commit d2dc2e6 into master Apr 12, 2018
@ghost
ghost deleted the getSynthesizedDeepCloneWithoutTrivia branch April 12, 2018 18:47
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhegazy @amcasey
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.