GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Correctly show instantiated signatures for JSX element signature help and quick info by weswigham · Pull Request #23492 · microsoft/TypeScript

Conversation

@weswigham

@weswigham Wesley Wigham (weswigham) commented Apr 17, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #22873
Fixes #22636

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Bnaya and styfle reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@weswigham
Correctly show instantiated signatures for JSX element signature help
218f758
@weswigham
Wesley Wigham (weswigham) requested review from Mohamed Hegazy (mhegazy) and Nathan Shively-Sanders (sandersn) April 17, 2018 22:48
@weswigham
Also bundle fix for quickinfo
9ab03c0
@weswigham Wesley Wigham (weswigham) changed the title Correctly show instantiated signatures for JSX element signature help Correctly show instantiated signatures for JSX element signature help and quick info Apr 18, 2018
@weswigham
Use more complete cache to avoid duplicate errors
4c094cb
@ajafff Klaus Meinhardt (ajafff) mentioned this pull request Apr 26, 2018
signature help of tagged template doesn't show instantiated signature #23716
Closed
@weswigham
Merge branch 'master' into jsx-signature-help
2281738
@weswigham Wesley Wigham (weswigham) mentioned this pull request May 4, 2018
Parse and check type arguments on JSX opening and self-closing tags #22415
Merged
mhegazy
Mohamed Hegazy (mhegazy) approved these changes May 16, 2018
View reviewed changes
@mhegazy

Mohamed Hegazy (mhegazy) commented May 16, 2018

Copy link
Copy Markdown
Contributor

Nathan Shively-Sanders (@sandersn) can you also take a look
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@weswigham
Wesley Wigham (weswigham) merged commit e01c7d2 into microsoft:master May 16, 2018
@weswigham

Wesley Wigham (weswigham) commented May 16, 2018

Copy link
Copy Markdown
Member Author

Mohamed Hegazy (@mhegazy) do I need to port this to the 2.9 branch?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented May 16, 2018

Copy link
Copy Markdown
Member

I think this broke the build. It needs to use verify.signatureHelp({text: "..."}) instead of verify.SignatureHelpIs("...")
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@weswigham
Wesley Wigham (weswigham) deleted the jsx-signature-help branch May 16, 2018 20:47
@weswigham

Wesley Wigham (weswigham) commented May 16, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Older PRs are great 😉 I've opened (and then merged) #24179 with the fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost mentioned this pull request May 17, 2018
Reduce map lookups #24203
Merged
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn
1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@weswigham @mhegazy @sandersn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.