GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Look at simplified types when checking distributive conditional constraints by weswigham · Pull Request #23884 · microsoft/TypeScript

Conversation

@weswigham

@weswigham Wesley Wigham (weswigham) commented May 4, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In #23592 we changed the getConstraintOfType function to not simplify index types - distributive conditional type constraints rely on the type being simplified to actually have something to iterate over, ergo getConstraintOfDistributiveConditionalType must call getSimplifiedType itself.

Fixes #23849

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@weswigham
Look at simplified types when checking distributive conditional const…
8b17726 
…raints
@weswigham
Wesley Wigham (weswigham) requested review from Anders Hejlsberg (ahejlsberg) and Mohamed Hegazy (mhegazy) May 4, 2018 00:26
@weswigham Wesley Wigham (weswigham) mentioned this pull request May 4, 2018
Non-null assertion doesn't work for mapped types #23849
Closed
ahejlsberg
Anders Hejlsberg (ahejlsberg) approved these changes May 4, 2018
View reviewed changes
@weswigham
Wesley Wigham (weswigham) merged commit 618da24 into microsoft:master May 4, 2018
@weswigham
Wesley Wigham (weswigham) deleted the conditional-constraint-distributivity branch May 4, 2018 21:35
@trshafer Thomas Shafer (trshafer) mentioned this pull request Jun 13, 2018
Generics do not preserve scoped union type of enums #24919
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ahejlsberg Anders Hejlsberg (ahejlsberg) ahejlsberg approved these changes
@mhegazy Mohamed Hegazy (mhegazy) Awaiting requested review from mhegazy

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@weswigham @ahejlsberg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.