GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Simplify getOutputExtension · Pull Request #23889 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented May 4, 2018

Copy link
Copy Markdown

Noticed while reviewing #22167 -- this appears to just be a boolean check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Simplify getOutputExtension
06dab5e
@ghost
ghost requested a review from Sheetal Nandi (sheetalkamat) May 4, 2018 15:58
@RyanCavanaugh

Ryan Cavanaugh (RyanCavanaugh) commented May 4, 2018

Copy link
Copy Markdown
Member

What happened to calling isSourceFileJavaScript? This could have impact on API consumers since that flag ultimately originates from createSourceFile's scriptKind
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Andy Hanson
Use isSourceFileJavaScript
6281ffd
@ghost

Deleted user (ghost) commented May 4, 2018

Copy link
Copy Markdown
Author

If so, it sounds like we should be relying on sourceFile.scriptKind all the time instead of fileExtensionIs if those many not be equivalent?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Aug 2, 2018

Copy link
Copy Markdown
Contributor

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) closed this Aug 2, 2018
@RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) deleted the getOutputExtension branch June 16, 2022 22:08
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) Awaiting requested review from sheetalkamat

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@RyanCavanaugh @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.