GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support recommended completion for union · Pull Request #24326 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented May 22, 2018

Copy link
Copy Markdown

Fixes #24304

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Support recommended completion for union
5d522b1
@ghost
ghost requested a review from Sheetal Nandi (sheetalkamat) May 22, 2018 18:46
@ghost
ghost force-pushed the completionsRecommended_union branch from 210d8b8 to 5d522b1 Compare May 22, 2018 18:46
mhegazy
Mohamed Hegazy (mhegazy) approved these changes May 22, 2018
View reviewed changes
sheetalkamat
Sheetal Nandi (sheetalkamat) reviewed May 22, 2018
View reviewed changes
Comment thread tests/cases/fourslash/completionsRecommended_union.ts
{
marker: "b",
// Arbitrarily chooses one to be recommended
includes: [{ name: "E", isRecommended: true, }, { name: "E2" }],

@sheetalkamat Sheetal Nandi (sheetalkamat) May 22, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not E2 to be recommended as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ghost Deleted user (ghost) May 22, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the original design (#20020) there can only be one recommended completion -- editors may be expecting this. We could add more than one but it would mean more work for editors and I think that's why we avoided it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Fix for empty enum, which is not a union
52740a2
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes May 22, 2018
View reviewed changes
@ghost
ghost merged commit 9cda2bd into master May 22, 2018
@ghost
ghost deleted the completionsRecommended_union branch May 22, 2018 20:38
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jul 31, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhegazy @sheetalkamat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.