GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — 🤖 User test baselines have changed by typescript-bot · Pull Request #26712 · microsoft/TypeScript

Conversation

@typescript-bot

@typescript-bot TypeScript Bot (typescript-bot) commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc Wesley Wigham (@weswigham) Nathan Shively-Sanders (@sandersn) Ryan Cavanaugh (@RyanCavanaugh)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@typescript-bot
Update user baselines
f66fcbe
@typescript-bot
TypeScript Bot (typescript-bot) requested review from Ryan Cavanaugh (RyanCavanaugh), Nathan Shively-Sanders (sandersn) and Wesley Wigham (weswigham) August 28, 2018 13:32
@typescript-bot
TypeScript Bot (typescript-bot) force-pushed the user-update-20180702 branch from 6914a61 to f66fcbe Compare August 28, 2018 13:34
sandersn
Nathan Shively-Sanders (sandersn) requested changes Aug 28, 2018
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anders Hejlsberg (@ahejlsberg)
Looks like #26698 incorrectly removed a couple of good errors in unions. Specifically, chrome-devtools-frontend has code equivalent to this:

class C {
  constructor(descriptors: (string | symbol | string[])[][]) {
    for (var i = 0; i < descriptors.length; ++i) {
      this[descriptors[i][1]] = // ...... more code here
  }
}

This previously gave the error "string[] cannot be used as an index type", which seems correct to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread tests/baselines/reference/user/chrome-devtools-frontend.log
Index signature is missing in type '{}'.
node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(407,19): error TS2694: Namespace 'Adb' has no exported member 'Config'.
node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(445,48): error TS2694: Namespace 'InspectorFrontendHostAPI' has no exported member 'ContextMenuDescriptor'.
node_modules/chrome-devtools-frontend/front_end/host/InspectorFrontendHost.js(471,12): error TS2538: Type 'string[]' cannot be used as an index type.

@sandersn Nathan Shively-Sanders (sandersn) Aug 28, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a result of #26698, possibly incorrect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Aug 28, 2018
Improve indexed access type relations #26698
Merged
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Aug 28, 2018
Regression - able to use union containing non-indexing type as index #26714
Closed
@sandersn Nathan Shively-Sanders (sandersn) closed this Aug 29, 2018
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn requested changes
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh
@weswigham Wesley Wigham (weswigham) Awaiting requested review from weswigham

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@typescript-bot @sandersn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.