GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add sortText depending scope of symbols by sheetalkamat · Pull Request #31484 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented May 20, 2019

Copy link
Copy Markdown
Member

Fixes #15024

Sorting done as per #15024 (comment)
Sorting as per #15024 (comment) is more complicated and needs more thought so for now enabling simple sorting.

  1. Things from the lexical scope that are declared in the current file (including top-level variables in a script file)
  2. Suggested class members
  3. Things from global lexical scope and keywords
  4. Auto-import suggestions
  5. JavaScript identifiers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Add sortText depending scope of symbols
00cea41 
Fixes #15024
@sheetalkamat
Sheetal Nandi (sheetalkamat) requested review from Ryan Cavanaugh (RyanCavanaugh), Andrew Branch (andrewbranch), Ron Buckton (rbuckton), Nathan Shively-Sanders (sandersn) and Wesley Wigham (weswigham) May 20, 2019 22:56
weswigham
Wesley Wigham (weswigham) approved these changes May 21, 2019
View reviewed changes

@weswigham Wesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked vscode issue mentioned something about a "location bonus" - is that further refining the order of zero-ranked completions on the vscode side by using brace matching and proximity?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat

Sheetal Nandi (sheetalkamat) commented May 21, 2019

Copy link
Copy Markdown
Member Author

Wesley Wigham (@weswigham) yes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit 38f689d into master May 21, 2019
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the completionsSorting branch May 21, 2019 19:59
@svipas Benas Svipas (svipas) mentioned this pull request May 26, 2019
Sorted/prioritized completions microsoft/vscode#74348
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Sheetal Nandi (sheetalkamat) Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@sandersn Nathan Shively-Sanders (sandersn) Awaiting requested review from sandersn
@andrewbranch Andrew Branch (andrewbranch) Awaiting requested review from andrewbranch
@rbuckton Ron Buckton (rbuckton) Awaiting requested review from rbuckton
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sheetalkamat Sheetal Nandi (sheetalkamat)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

favor local types and values in autocomplete popup over ambients declaration

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sheetalkamat @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.