GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix assignment to property of 'this' though index signature by ahejlsberg · Pull Request #31704 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented May 31, 2019

Copy link
Copy Markdown
Member

Fixes #31691.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Anders Hejlsberg (ahejlsberg) added 3 commits May 31, 2019 11:03
@ahejlsberg
Permit assignment this.xxx when class has index signature
aaa5592
@ahejlsberg
Add regression test
59dc857
@ahejlsberg
Accept new baselines
d99b73c
@ahejlsberg
Anders Hejlsberg (ahejlsberg) requested a review from Ryan Cavanaugh (RyanCavanaugh) May 31, 2019 18:06
RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh) approved these changes May 31, 2019
View reviewed changes
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit 487bd78 into master May 31, 2019
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the fixThisIndexSignatureAssignment branch May 31, 2019 19:49
@justingrant Justin Grant (justingrant) mentioned this pull request Jun 3, 2019
3.5.1 regression when using this with an index signature of a generic union type #31731
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Anders Hejlsberg (ahejlsberg) Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) RyanCavanaugh approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ahejlsberg Anders Hejlsberg (ahejlsberg)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[3.5.1] Class index signature stopped working - property does not exist on type

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ahejlsberg @RyanCavanaugh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.