GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Don’t auto-import undefined by andrewbranch · Pull Request #35504 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Dec 4, 2019

Copy link
Copy Markdown
Member

Fixes #35458

An external module that exports undefined caused some code added in #32517 to crash. It turns out I was unable to actually reproduce that exact crash in a failing test because the test harness throws immediately upon discovering multiple completions for undefined, which is pretty fair, so I
now filter undefined from being considered as an auto-import altogether.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch
Don’t auto-import undefined
60df537
@andrewbranch
Andrew Branch (andrewbranch) requested review from Orta Therox (orta) and Sheetal Nandi (sheetalkamat) December 4, 2019 19:59
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes Dec 5, 2019
View reviewed changes
orta
Orta Therox (orta) approved these changes Dec 5, 2019
View reviewed changes
@andrewbranch
Andrew Branch (andrewbranch) merged commit f050750 into microsoft:master Dec 5, 2019
@yamachu Yusuke Yamada (yamachu) mentioned this pull request Dec 7, 2019
TypeError: Cannot read property 'symbol' of undefined in 'unknown' during 'completionInfo' #35036
Closed
@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 4, 2020

Copy link
Copy Markdown
Member

Also fixes #35036, as far as I can tell, since repros have stopped coming in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Mar 5, 2020
Write intended fix for #35036 by @josheplibra to src #35232
Closed
[FIX] empty-import for the correct operation of intellisense in VScode #35370
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
+1 more reviewer
@orta Orta Therox (orta) orta approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intellisense stops working when TS Server is higher version

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@andrewbranch @sandersn @orta @sheetalkamat
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.