GeezerVison is showing github.com — Add top-level await for esnext and system modules by rbuckton · Pull Request #35813 · microsoft/TypeScript
Conversation
This removes our restriction around using an await expression at the top level of a file when the following conditions are met:
- The containing file is an external module (or
--isolatedModules is provided)
- The
--target is >= ScriptTarget.ES2017 (minimum version required for await keyword)
- The
--module is either esnext or system.
This is not currently supported for earlier script targets (e.g., ES2016, ES2015, ES5, ES3) as the system transform currently happens after async functions and generators have been transformed, so it is too late to transform the async function that is created as part of the system module transform. This also ensures it is consistent with --target es5 --module esnext, as there would be no way to down-level the await in that context either.
Fixes #25988, #32793
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
saschanaz, brainkim, ExE-Boss, MitchTalmadge, matijagrcic, islishude, fuafa, btoo, aryzing, delzennejc, and 17 more reacted with thumbs up emoji
shreyasminocha, brainkim, MitchTalmadge, sumitmckv, ryasmi, chicoxyzzy, dekhanov, aryzing, ExE-Boss, tomironkko, and 6 more reacted with hooray emoji
mightyiam, matijagrcic, aryzing, ExE-Boss, rayhanw, and emadgit reacted with heart emoji
ExE-Boss, emadgit, and SergeITinc reacted with rocket emoji
brainkim, emadgit, and SergeITinc reacted with eyes emoji
All reactions
-
👍
27 reactions
-
🎉
16 reactions
-
❤️
6 reactions
-
🚀
3 reactions
-
👀
3 reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Top Level Await
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|