GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(36048): Apply uncalled function checks to ternaries by a-tarasyuk · Pull Request #36402 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Jan 24, 2020

Copy link
Copy Markdown
Contributor

Fixes #36048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kenrick95, SlurpTheo, bmind12, and Milly reacted with thumbs up emoji
All reactions
  • 👍 4 reactions
@a-tarasyuk
feat(36048): handle uncalled function checks in ternaries
94dbe2f
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested review from Daniel Rosenwasser (DanielRosenwasser) and Sheetal Nandi (sheetalkamat) January 24, 2020 15:11
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Wesley Wigham (weswigham) January 28, 2020 19:34
@sandersn

Nathan Shively-Sanders (sandersn) commented Jan 28, 2020

Copy link
Copy Markdown
Member

Wesley Wigham (@weswigham) and Daniel Rosenwasser (@DanielRosenwasser) are probably the best reviewers for this.
a-tarasyuk reacted with thumbs up emoji a-tarasyuk reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
weswigham
Wesley Wigham (weswigham) approved these changes Jan 28, 2020
View reviewed changes

@weswigham Wesley Wigham (weswigham) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a striaghtforward generalization of the if machinery to ternaries to me~

The only thing I could add is that it's maybe also extendable to && (and ?? assuming we don't already issue an error there), so we could also probably check binary expressions in this way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jan 28, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the parallelized community code test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 28, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the extended test suite on this PR at 94dbe2f. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Jan 28, 2020

Copy link
Copy Markdown
Member

With 3.8 leaving beta at end of week, let's hold this until 3.9.
DanielRosenwasser reacted with thumbs up emoji a-tarasyuk reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Jan 28, 2020
🤖 User test baselines have changed for feature/36048 a-tarasyuk/TypeScript#1
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Jan 28, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn Nathan Shively-Sanders (sandersn) added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 1, 2020
Oleksandr Tarasiuk (a-tarasyuk) added 2 commits February 7, 2020 18:20
@a-tarasyuk
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
409b427 
… feature/36048
@a-tarasyuk
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
a46df50 
… feature/36048
@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Feb 10, 2020

Copy link
Copy Markdown
Contributor Author

The following lines cause the error

TypeScript/src/server/project.ts

Line 1382 in fa3173f

updated: includeProjectReferenceRedirectInfoIfRequested

TypeScript/src/server/project.ts

Line 1312 in fa3173f

const includeProjectReferenceRedirectInfoIfRequested =

Is it the right condition in this case?

cc Nathan Shively-Sanders (@sandersn) Daniel Rosenwasser (@DanielRosenwasser) Wesley Wigham (@weswigham)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 19, 2020

Copy link
Copy Markdown
Member

Yes, those errors are correct, and they should be fixed before merging this PR. I asked Ben Lichtman (@uniqueiniquity) to investigate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 20, 2020

Copy link
Copy Markdown
Member

Fix is #36885, thanks Ben Lichtman (@uniqueiniquity) for figuring it out.
a-tarasyuk reacted with thumbs up emoji a-tarasyuk reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Feb 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Nathan Shively-Sanders (@sandersn) Oke, I'll wait for merge PR #36885.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 20, 2020

Copy link
Copy Markdown
Member

OK, Oleksandr Tarasiuk (@a-tarasyuk) can you merge from master and I'll re-run the user tests to make sure they're still good.
a-tarasyuk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
0c06464 
… feature/36048
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 20, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) test this
TypeScript Bot (@typescript-bot) user test this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Nathan Shively-Sanders (@sandersn), I've started to run the extended test suite on this PR at 0c06464. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Nathan Shively-Sanders (@sandersn), I've started to run the parallelized community code test suite on this PR at 0c06464. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot TypeScript Bot (typescript-bot) mentioned this pull request Feb 20, 2020
🤖 User test baselines have changed for feature/36048 a-tarasyuk/TypeScript#2
Closed
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

user and RWC tests look clean
(and node 12 failure on devops is bogus)
a-tarasyuk reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Nathan Shively-Sanders (sandersn) merged commit bf6be75 into microsoft:master Feb 20, 2020
@IllusionMH Andrii Dieiev (IllusionMH) mentioned this pull request Feb 21, 2020
Implicit type coersion of function to boolean in ternary operator #36921
Closed
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) mentioned this pull request Aug 25, 2020
No "did you mean to call" error when invocation is part of a logical expression #40197
Closed
@soffes Sam Soffes (soffes) mentioned this pull request Sep 24, 2021
Apply uncalled function checks to boolean expressions (ts2774) #46051
Open
5 tasks done
@github-actions github-actions Bot mentioned this pull request Aug 14, 2022
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
@typescript-bot TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn) Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
@sheetalkamat Sheetal Nandi (sheetalkamat) Awaiting requested review from sheetalkamat

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply uncalled function checks to ternaries

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@a-tarasyuk @sandersn @DanielRosenwasser @typescript-bot @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.