GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(36249): Declare property quick fix should add private properties (or be configurable) by a-tarasyuk · Pull Request #36632 · microsoft/TypeScript

Conversation

@a-tarasyuk

@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Fixes #36249

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) requested a review from Daniel Rosenwasser (DanielRosenwasser) February 5, 2020 14:30
@a-tarasyuk Oleksandr Tarasiuk (a-tarasyuk) changed the title feat(36249): add quick-fix action to declare a property as private wh… feat(36249): Declare property quick fix should add private properties (or be configurable) Feb 5, 2020
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) marked this pull request as ready for review February 6, 2020 09:26
@sandersn Nathan Shively-Sanders (sandersn) added the For Backlog Bug PRs that fix a backlog bug label Feb 14, 2020
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feature/36249 branch from 744b863 to e8a2eae Compare February 17, 2020 13:20
@sandersn Nathan Shively-Sanders (sandersn) added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug and removed For Backlog Bug PRs that fix a backlog bug labels Mar 12, 2020
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Andrew Casey (amcasey) March 12, 2020 17:38
@sandersn Nathan Shively-Sanders (sandersn) assigned Andrew Casey (amcasey) Mar 12, 2020
amcasey
Andrew Casey (amcasey) approved these changes Mar 12, 2020
View reviewed changes

@amcasey Andrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick about the text. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.
Oleksandr Tarasiuk (a-tarasyuk) added 2 commits March 13, 2020 10:10
@a-tarasyuk
feat(36249): add quick-fix action to declare a property as private wh…
12f5b56 
…ich starts from underscore
@a-tarasyuk
Merge branch 'master' of https://github.com/Microsoft/TypeScript into…
099fe8f 
… feature/36249
@a-tarasyuk
Oleksandr Tarasiuk (a-tarasyuk) force-pushed the feature/36249 branch from b087ae0 to 099fe8f Compare March 13, 2020 08:18
amcasey
Andrew Casey (amcasey) approved these changes Mar 13, 2020
View reviewed changes
@amcasey
Andrew Casey (amcasey) merged commit b41eb1b into microsoft:master Mar 13, 2020
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Awaiting requested review from DanielRosenwasser
1 more reviewer
@amcasey Andrew Casey (amcasey) amcasey approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@amcasey Andrew Casey (amcasey)

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Declare property quick fix should add private properties (or be configurable)

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@a-tarasyuk @amcasey @sandersn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.