GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Throw syntax error for `}` and `>` in JSX text by bradzacher · Pull Request #36636 · microsoft/TypeScript

Conversation

@bradzacher

@bradzacher Brad Zacher (bradzacher) commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

Fixes #36341

This is my first PR for typescript, so please LMK if there's a better way to do this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
alloy and Gumichocopengin8 reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@bradzacher
Throw syntax error for } and > in JSX text
43e2ffa 
Fixes #36341
@msftclas

Microsoft Contribution License Agreements (msftclas) commented Feb 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta Orta Therox (orta) self-assigned this Feb 5, 2020
@orta

Orta Therox (orta) commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

This is great, I don't have any code recommendations (given the simplicity of the implementation) and the tests look good. I went to check babels implementation details only to find my way back to the linked issue.

My only question is do you want to add a codefix for these too?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bradzacher

Brad Zacher (bradzacher) commented Feb 5, 2020

Copy link
Copy Markdown
Contributor Author

only to find my way back to the linked issue

Yeah sorry, I raised issues in acorn, babel and typescript together (and PR'd it into babel) 😄

My only question is do you want to add a codefix for these too?

Sure, I'd love to!
Just triple checking my understanding of the codebase is right - is this the correct place to learn about, and add code fixes?
https://github.com/microsoft/TypeScript/tree/master/src/services/codefixes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@a-tarasyuk

Oleksandr Tarasiuk (a-tarasyuk) commented Feb 5, 2020

Copy link
Copy Markdown
Contributor

is this the correct place to learn about, and add code fixes?

Yes, it is the right place (:
bradzacher reacted with thumbs up emoji orta reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bradzacher
Add codefix for error
0e35097
@bradzacher

Brad Zacher (bradzacher) commented Feb 6, 2020

Copy link
Copy Markdown
Contributor Author

Took me a minute to figure everything out, but I got there in the end.
LMK if the codefix implementation looks good.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

This looks perfect, thanks Brad Zacher (@bradzacher) 👍
bradzacher reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta
Orta Therox (orta) merged commit 348c4dd into microsoft:master Feb 11, 2020
@bradzacher
Brad Zacher (bradzacher) deleted the 36341-dangling-jsx branch February 11, 2020 16:45
@sandersn Nathan Shively-Sanders (sandersn) mentioned this pull request Feb 12, 2020
react-native: add some missing props for TextInput DefinitelyTyped/DefinitelyTyped#42279
Merged
7 tasks done
@alloy

Eloy Durán (alloy) commented Feb 12, 2020

Copy link
Copy Markdown
Member

Nice one, immediately caught an error in a DT test case 👌
bradzacher reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bradzacher Brad Zacher (bradzacher) mentioned this pull request Feb 25, 2020
[no-delete-optional] Prohibit deleting optional properties typescript-eslint/typescript-eslint#1634
Closed
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Mar 16, 2020
Fixing > character in JSX text should have a "fix all in file" #37409
Closed
@bradzacher Brad Zacher (bradzacher) mentioned this pull request Mar 23, 2020
Rule suggestion: Prefer "import type" typescript-eslint/typescript-eslint#1786
Closed
@github-actions github-actions Bot mentioned this pull request Aug 14, 2022
Remove span tag in title and unnecessary TOC in Ko microsoft/TypeScript-Website-Localizations#164
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@orta Orta Therox (orta)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: throw syntax error for } and > in JSX text.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@bradzacher @msftclas @orta @a-tarasyuk @alloy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.