GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support property declarations in jsdoc template generation by sandersn · Pull Request #36658 · microsoft/TypeScript

Conversation

@sandersn

@sandersn Nathan Shively-Sanders (sandersn) commented Feb 6, 2020

Copy link
Copy Markdown
Member

JSDoc template generation now supports property declarations with function initialisers.

Fixes #28786

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn
Support property declarations in jsdoc template generation
bd9daf3
@typescript-bot TypeScript Bot (typescript-bot) assigned Nathan Shively-Sanders (sandersn) Feb 6, 2020
@typescript-bot TypeScript Bot (typescript-bot) added the Author: Team label Feb 6, 2020
@sandersn
Nathan Shively-Sanders (sandersn) requested review from Andrew Branch (andrewbranch) and Orta Therox (orta) February 6, 2020 17:29
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 6, 2020

Copy link
Copy Markdown
Member Author

Ben Lichtman (@uniqueiniquity) Tagging you since github suggested you as a reviewer -- in case you care about this feature.
uniqueiniquity reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
uniqueiniquity
Ben Lichtman (uniqueiniquity) reviewed Feb 6, 2020
View reviewed changes
Comment thread tests/cases/fourslash/docCommentTemplateClassDeclProperty01.ts
//// return p0;
//// };
//// /*1*/
//// bar = (p1) => {

@uniqueiniquity Ben Lichtman (uniqueiniquity) Feb 6, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also test the function expression case?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sandersn Nathan Shively-Sanders (sandersn) Feb 6, 2020

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
andrewbranch
Andrew Branch (andrewbranch) approved these changes Feb 6, 2020
View reviewed changes
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 6, 2020

Copy link
Copy Markdown
Member Author

Build failed because of space lint.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
fix lint and add test
e1cc9f2
@sandersn

Nathan Shively-Sanders (sandersn) commented Feb 6, 2020

Copy link
Copy Markdown
Member Author

Relevant: Key to planet formation found in space lint:

https://www.space.com/3315-key-planet-formation-space-lint.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sandersn
Nathan Shively-Sanders (sandersn) merged commit 2cc5856 into master Feb 6, 2020
@sandersn
Nathan Shively-Sanders (sandersn) deleted the jsdoc-template-for-property-decl branch February 6, 2020 22:39
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes
@orta Orta Therox (orta) Awaiting requested review from orta
+1 more reviewer
@uniqueiniquity Ben Lichtman (uniqueiniquity) uniqueiniquity left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

Author: Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docCommentTemplate not returned for assigned method in class

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sandersn @andrewbranch @uniqueiniquity @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.