GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags by amcasey · Pull Request #36947 · microsoft/TypeScript

Conversation

@amcasey

@amcasey Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member

...to save space (and possibly to reduce de-opts, since it appears to be lazily set).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@amcasey
Convert UnionOrIntersectionType.couldContainTypeVariables to ObjectFlags
2e9972d 
...to save space (and possibly to reduce de-opts, since it appears to be
lazily set).
@amcasey

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Modelled on #36622.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amcasey
Andrew Casey (amcasey) requested review from Ryan Cavanaugh (RyanCavanaugh) and Anders Hejlsberg (ahejlsberg) February 21, 2020 22:33
@amcasey

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

This seems unlikely to affect the perf tests, since it mostly applies to intersection and union types, which are not represented in the perf suite.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amcasey

Andrew Casey (amcasey) commented Feb 21, 2020

Copy link
Copy Markdown
Member Author

Ugh, muscle memory...
TypeScript Bot (@typescript-bot) perf test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Feb 21, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Andrew Casey (@amcasey), I've started to run the perf test suite on this PR at 2e9972d. You can monitor the build here. It should now contribute to this PR's status checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amcasey Andrew Casey (amcasey) mentioned this pull request Feb 22, 2020
Use couldContainTypeVariables to short-circuit instantiateType #36951
Merged
@amcasey
Andrew Casey (amcasey) requested a review from Wesley Wigham (weswigham) February 25, 2020 01:51
@amcasey Andrew Casey (amcasey) closed this Feb 25, 2020
@amcasey Andrew Casey (amcasey) reopened this Feb 25, 2020
weswigham
Wesley Wigham (weswigham) approved these changes Feb 25, 2020
View reviewed changes

@weswigham Wesley Wigham (weswigham) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforwardly good to me, and we can always shuffle around the object flags later if need be.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@amcasey
Andrew Casey (amcasey) merged commit b5bd38b into microsoft:master Feb 25, 2020
@amcasey
Andrew Casey (amcasey) deleted the CouldContainFlag branch February 25, 2020 02:18
@amcasey

Andrew Casey (amcasey) commented Feb 25, 2020

Copy link
Copy Markdown
Member Author

Wesley Wigham (@weswigham) Finders keepers 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@weswigham Wesley Wigham (weswigham) weswigham approved these changes
@ahejlsberg Anders Hejlsberg (ahejlsberg) Awaiting requested review from ahejlsberg
@RyanCavanaugh Ryan Cavanaugh (RyanCavanaugh) Awaiting requested review from RyanCavanaugh

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@amcasey @typescript-bot @weswigham
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.