GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Convert to async function: handle type arguments to then/catch by andrewbranch · Pull Request #37463 · microsoft/TypeScript Conversation
Member
I think this addresses what should be a real edge case, as there’s not a great reason to supply a type argument to // logs some stuff about any argument and returns it declare function logWhenDebugging<T>(x: T): T; // SOURCE // inferred return type: Promise<User> function fetch() { const promiseOfAny = Promise.resolve(undefined as any); return promiseOfAny.then<User>(x => logWhenDebugging(x)); } // BEFORE: we drop the type argument // inferred return type: Promise<any> async function fetch() { const promiseOfAny = Promise.resolve(undefined as any); const x = await promiseOfAny; return logWhenDebugging(x); } // AFTER: new variable declaration to preserve it // inferred return type: Promise<User> async function fetch() { const promiseOfAny = Promise.resolve(undefined as any); const x = await promiseOfAny; const result: User = logWhenDebugging(x); return result; } Fixes #28529
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Andrew Branch (andrewbranch)
requested review from
Sheetal Nandi (sheetalkamat) and
Ben Lichtman (uniqueiniquity)
Uh oh!
There was an error while loading. Please reload this page.
Ben Lichtman (uniqueiniquity)
approved these changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesLabelsProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Convert to async function refactoring loses generic parameterUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |