GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add logical assignment operator by Kingwl · Pull Request #37727 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Apr 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #37255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ExE-Boss, acrazing, stefnotch, FFKL, wongmjane, ChayimFriedman2, g-patel, chocolateboy, and apalanki reacted with thumbs up emoji ExE-Boss reacted with hooray emoji leonardodino, dragomirtitian, IllusionMH, dashed, MattiasBuelens, kitos, tomholford, codler, and maykon-oliveira reacted with heart emoji ExE-Boss reacted with rocket emoji dashed reacted with eyes emoji
All reactions
  • 👍 9 reactions
  • 🎉 1 reaction
  • ❤️ 9 reactions
  • 🚀 1 reaction
  • 👀 1 reaction
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The GitHub app is terrible so I can't review properly, but test 5 uses a function type returning void | undefined. That's probably a mistake.

Resolved
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 1, 2020
View reviewed changes
Comment thread tests/baselines/reference/logicalAssignment5(target=es2020).errors.txt
}

function foo2 (f?: (a: number) => void) {
f ||= (a => a)

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 1, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Kingwl Wenlu Wang (Kingwl) Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 1, 2020
View reviewed changes
Comment thread tests/baselines/reference/logicalAssignment4(target=es2015).errors.txt
if (thing &&= thing.original) {
console.log(thing.name);
~~~~~
!!! error TS2532: Object is possibly 'undefined'.

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 1, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the test caught this - that was part of my intent when I wrote it. As you probably know, this needs to be fixed because thing.original should be defined. Let Anders Hejlsberg (@ahejlsberg) or Ron Buckton (@rbuckton) know if you need help with that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Kingwl Wenlu Wang (Kingwl) Apr 1, 2020

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent all afternoon And evening in this one😂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 2, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the code can be hard to get through, and I've honestly never wired up the CFG. Also, binary expressions recently changed to use a "trampolining" approach to avoid stack overflows on deep traversals. You can ask Wesley Wigham (@weswigham) about that.

If you want to play around to see if you can get it working, I'll provide a few tips and Wesley Wigham (@weswigham) and Anders Hejlsberg (@ahejlsberg) can weigh in case I'm totally off.

First take a look at some of the logic at

TypeScript/src/compiler/binder.ts

Line 1418 in b58a29b

const preRightLabel = createBranchLabel();

and

TypeScript/src/compiler/binder.ts

Line 1513 in b58a29b

if (operator === SyntaxKind.AmpersandAmpersandToken || operator === SyntaxKind.BarBarToken || operator === SyntaxKind.QuestionQuestionToken) {

The binder needs to create branch labels for these new compound assignment operators (similar to in bindLogicalExpression) while creating at least one flow node that's considered an assignment after the expression (as in bindAssignmentTargetFlow). At a glance, I think that a lot of the logic can be reused and the changes can be added around here

Eventually in getTypeAtFlowNode in the type-checker, you need to try to find a way to combine the logic when flags & FlowFlags.Assignment and flags & FlowFlags.Label both apply. To start, I'd just get something working, then worry about how to share the code.

Feel free to ask some questions if you need help. If you'd prefer, I'm also sure we could send a PR if you'd like, but it's up to you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 1, 2020
View reviewed changes
Comment thread src/compiler/utilities.ts Outdated
|| token === SyntaxKind.ExclamationToken;
}

export function isLogicalAssignmentOperator(token: SyntaxKind): boolean {

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 1, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider isShortCircuitingAssignmentOperator or isLogicalOrCoalescingAssignmentOperator

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 1, 2020
View reviewed changes
Comment thread src/compiler/utilities.ts Outdated
return 14;
case SyntaxKind.AsteriskAsteriskToken:
return 15;
case SyntaxKind.BarBarEqualsToken:

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 1, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section doesn't seem to cover any of the assignment or compound assignment operators. I'd get clarity from whoever originally wrote this function whether this should be here, because I think these 3 cases don't belong here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) Apr 1, 2020

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to be caught by getOperatorPrecedence above.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 1, 2020
View reviewed changes
Comment thread src/compiler/transformers/utilities.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested changes Apr 1, 2020
View reviewed changes
Comment thread src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl
Wenlu Wang (Kingwl) force-pushed the logical_assignment branch from 2f6dfd7 to 1c92781 Compare April 2, 2020 08:04
@Kingwl

Wenlu Wang (Kingwl) commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

It seems works, but i don't know why.🤷🏻‍♂️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 2, 2020

Copy link
Copy Markdown
Member

TypeScript Bot (@typescript-bot) pack this
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Daniel Rosenwasser (@DanielRosenwasser), I've started to run the tarball bundle task on this PR at 1c92781. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 2, 2020
View reviewed changes
Comment thread src/compiler/binder.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 2, 2020
View reviewed changes
Comment thread src/compiler/binder.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) reviewed Apr 2, 2020
View reviewed changes
Comment thread src/compiler/binder.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

Current CFG is

"
Call (results.push(100)) ─ ArrayMutation (results.push(100)) ─ Branch ┬ True (results) ─────────────────────────────────────────────────┬ Start  
                                                                      ├ True (results ||= []) ─┬ Assignment (results) ─ False (results) ╯   
                                                                      ╰ False (results ||= []) ╯                                            
"

the same as downlevel result

"
Call (results.push(100)) ─ ArrayMutation (results.push(100)) ─ Branch ┬ True (results) ─────────────────────────────────────────────────┬ Start  
                                                                      ├ True ((results = [])) ─┬ Assignment (results) ─ False (results) ╯   
                                                                      ╰ False ((results = [])) ╯                                            
"
DanielRosenwasser reacted with thumbs up emoji DanielRosenwasser reacted with hooray emoji DanielRosenwasser reacted with heart emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented Apr 2, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at a6e0086. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 2, 2020

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/70160/artifacts?artifactName=tgz&fileId=686926927B2177B6DF8E5E65AF663CA3F21F8E4A6BB13BA2F0D55123942814F102&fileName=/typescript-3.9.0-insiders.20200402.tgz"
    }
}

and then running npm install.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl
Wenlu Wang (Kingwl) force-pushed the logical_assignment branch from 17b858c to 1ed6a3e Compare April 4, 2020 14:11
@Kingwl
Wenlu Wang (Kingwl) marked this pull request as ready for review April 4, 2020 14:32
@Kingwl

Wenlu Wang (Kingwl) commented Apr 4, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 4, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 8a9e234. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/70428/artifacts?artifactName=tgz&fileId=0F5F796F0B11C552E9CE937F66A4E8AFB940559C729165A9D4B3FAFEB190B56302&fileName=/typescript-3.9.0-insiders.20200404.tgz"
    }
}

and then running npm install.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl

Wenlu Wang (Kingwl) commented Apr 7, 2020

Copy link
Copy Markdown
Contributor Author

Does the playground not supported pull request build now?🤷🏻‍♂️
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Apr 7, 2020

Copy link
Copy Markdown
Member

Does the playground not supported pull request build now?

Wesley Wigham (@weswigham) or Orta Therox (@orta) might know
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Apr 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks for the ping, looks like I need to dig into the playground builder - been red for a week
https://github.com/orta/make-monaco-builds/actions - looks like a master build of TS gives a new error in the monaco-typescript codebase
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

Made a PR: microsoft/monaco-typescript#59
DanielRosenwasser reacted with thumbs up emoji DanielRosenwasser reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@orta

Orta Therox (orta) commented Apr 7, 2020

Copy link
Copy Markdown
Contributor

and with orta/make-monaco-builds@f17ca4a in

I can request a playground again - TypeScript Bot (@typescript-bot) pack this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Orta Therox (@orta), I've started to run the tarball bundle task on this PR at 8a9e234. You can monitor the build here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@typescript-bot

TypeScript Bot (typescript-bot) commented Apr 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Orta Therox (@orta), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/70644/artifacts?artifactName=tgz&fileId=C1043CC14B2BF52EEC192CF7805DCDB9972F4A315657B65C7F9096429256B57A02&fileName=/typescript-3.9.0-insiders.20200407.tgz"
    }
}

and then running npm install.

There is also a playground for this build.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl
add missing semi
39ae072
@Kingwl
Wenlu Wang (Kingwl) force-pushed the logical_assignment branch from f17eb88 to 39ae072 Compare May 16, 2020 00:11
Wenlu Wang (Kingwl) added 2 commits May 16, 2020 08:13
@Kingwl
fix rebase conflict
acc167d
@Kingwl
accept new baseline
6f393e9
@Kingwl

Wenlu Wang (Kingwl) commented May 16, 2020

Copy link
Copy Markdown
Contributor Author

Only one pipeline failed with ECONNRESET.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 20, 2020

Copy link
Copy Markdown
Member

Looks like this needs to be rebased onto the latest master.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested changes May 20, 2020
View reviewed changes
Comment thread src/compiler/parser.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Kingwl
Merge branch 'master' into logical_assignment
b59e4c5
@Kingwl
Wenlu Wang (Kingwl) force-pushed the logical_assignment branch from ad70d78 to b59e4c5 Compare May 20, 2020 02:18
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 20, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

One more review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rbuckton
Ron Buckton (rbuckton) suggested changes May 20, 2020
View reviewed changes
Comment thread tests/cases/conformance/esnext/logicalAssignment/logicalAssignment2.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/baselines/reference/logicalAssignment5(target=es2015).errors.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/transformers/esnext.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/transformers/esnext.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/transformers/esnext.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/compiler/transformers/esnext.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Wenlu Wang (Kingwl) added 3 commits May 21, 2020 10:19
@Kingwl
Fix type and simplify code
b73411c
@Kingwl
fix names
2997860
@Kingwl
Accept baseline
fed922a
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented May 27, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

One more peek Ron Buckton (@rbuckton)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) approved these changes May 27, 2020
View reviewed changes
@Kingwl

Wenlu Wang (Kingwl) commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

up👆
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rbuckton
Ron Buckton (rbuckton) approved these changes Jun 9, 2020
View reviewed changes
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit e832e04 into microsoft:master Jun 9, 2020
@Kingwl
Wenlu Wang (Kingwl) deleted the logical_assignment branch June 10, 2020 00:35
@aminpaks

Amin Pakseresht (aminpaks) commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Wenlu Wang (@Kingwl) I mentioned a case in here. Would you confirm that this is not a bug?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanw Evan Wallace (evanw) mentioned this pull request Jun 20, 2020
Side effect bugs with logical assignment #39172
Closed
@Xample

Flavien Volken (Xample) commented Jul 24, 2020

Copy link
Copy Markdown

Glad to see things moved since #20378 😀
DanielRosenwasser reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jcalz Joe Calzaretta (jcalz) mentioned this pull request Aug 7, 2020
Logical Unary Assignment Operators &&= and ||= #31011
Closed
@g-patel

Gaurang Patel (g-patel) commented Sep 3, 2020

Copy link
Copy Markdown

What version of typescript will this be available in?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ExE-Boss

ExE Boss (ExE-Boss) commented Sep 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Gaurang Patel (@g-patel) This shipped in TypeScript 4.0.
LinusU reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@schickling Johannes Schickling (schickling) mentioned this pull request Jan 27, 2021
Support logical assignment operator evanw/esbuild#715
Closed
@jonculver Jon Culver (jonculver) mentioned this pull request Jul 13, 2021
Extension fails to load on remotes microsoft/vscode-test-adapter-converter#5
Closed
@github-actions github-actions Bot mentioned this pull request Oct 4, 2022
[Korean] Fix weird expressions like '_제네릭_' microsoft/TypeScript-Website-Localizations#171
Merged
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser approved these changes
@ahejlsberg Anders Hejlsberg (ahejlsberg) Awaiting requested review from ahejlsberg
+1 more reviewer
@rbuckton Ron Buckton (rbuckton) rbuckton approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@elibarzilay Eli Barzilay (elibarzilay)

Labels

For Milestone Bug PRs that fix a bug with a specific milestone

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nullish Coalescing and Logical Compound Assignments (??=, ||=, &&=)

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@Kingwl @DanielRosenwasser @typescript-bot @orta @sandersn @elibarzilay @aminpaks @Xample @g-patel @ExE-Boss @rbuckton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.