GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — Add support for pedantic property access by Kingwl · Pull Request #40171 · microsoft/TypeScript Conversation
Contributor
Fixes #40170
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Wenlu Wang (Kingwl)
marked this pull request as draft
Wenlu Wang (Kingwl)
marked this pull request as ready for review
Nathan Shively-Sanders (sandersn)
requested changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some suggestions for the wording of messages.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Nathan Shively-Sanders (sandersn)
requested a review
from Andrew Branch (andrewbranch)
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Andrew Branch (andrewbranch)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Implementation looks good, Nathan Shively-Sanders (@sandersn)’s messaging suggestions look good
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Wenlu Wang (Kingwl)
requested a review
from Nathan Shively-Sanders (sandersn)
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Nathan Shively-Sanders (sandersn)
approved these changes
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll merge this after 4.1 RC.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
|
Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 9fad505. You can monitor the build here. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The TypeScript team hasn't accepted the linked issue #40170. This makes it less likely that we'll review or accept this PR. Try to get the originating issue accepted. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
pedanticPropertyLookup
There was an error while loading. Please reload this page.