GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add support for pedantic property access by Kingwl · Pull Request #40171 · microsoft/TypeScript

Conversation

@Kingwl

@Kingwl Wenlu Wang (Kingwl) commented Aug 21, 2020

Copy link
Copy Markdown
Contributor

Fixes #40170

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Kingwl
Add support for pedantic property access
7baf4f1
@Kingwl
Wenlu Wang (Kingwl) marked this pull request as draft August 21, 2020 09:34
@typescript-bot TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 21, 2020
@Kingwl
accept baseline
d44138d
@Kingwl
Wenlu Wang (Kingwl) marked this pull request as ready for review August 24, 2020 03:15
sandersn
Nathan Shively-Sanders (sandersn) requested changes Sep 8, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the wording of messages.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread src/compiler/diagnosticMessages.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

@sandersn Nathan Shively-Sanders (sandersn) self-assigned this Sep 8, 2020
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Andrew Branch (andrewbranch) September 8, 2020 15:53
@sandersn

Nathan Shively-Sanders (sandersn) commented Sep 8, 2020

Copy link
Copy Markdown
Member

Also, at the Friday (Sep 4) design meeting, we decided not to create a single naming scheme for pedantic options, but (1) to name them for what they do (2) use the "no-" prefix only if it makes sense, since we already have some pedantic options named that, like noUnusedLocals, noFallthroughCasesInSwitch, etc.

I would suggest noPropertyAccessFromIndexSignature.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andrewbranch
Andrew Branch (andrewbranch) approved these changes Sep 8, 2020
View reviewed changes

@andrewbranch Andrew Branch (andrewbranch) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, Nathan Shively-Sanders (@sandersn)’s messaging suggestions look good

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Wenlu Wang (Kingwl) added 3 commits September 9, 2020 10:56
@Kingwl
Merge branch 'master' into pedanticPropertyLookup
cc74be5
@Kingwl
Update diag message
a3f729b
@Kingwl
Avoid pedantic
3a1e53b
@ssledorze

ssledorze commented Sep 25, 2020

Copy link
Copy Markdown

Really useful and awaited! :)
Looking forward to that PR being merged..
Is there some information on the expected release it would be part of?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Kingwl
Merge branch 'master' into pedanticPropertyLookup
9fad505
@Kingwl
Wenlu Wang (Kingwl) requested a review from Nathan Shively-Sanders (sandersn) September 25, 2020 10:27
@Kingwl

Wenlu Wang (Kingwl) commented Sep 25, 2020

Copy link
Copy Markdown
Contributor Author

ssledorze After 4.1 release, I guess.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sandersn
Nathan Shively-Sanders (sandersn) approved these changes Oct 28, 2020
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this after 4.1 RC.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ssledorze

ssledorze commented Oct 28, 2020

Copy link
Copy Markdown

I'll merge this after 4.1 RC.

should I understand it will be in the 4.1 release Nathan Shively-Sanders (@sandersn) ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sandersn

Nathan Shively-Sanders (sandersn) commented Oct 28, 2020

Copy link
Copy Markdown
Member

No, we're finishing up 4.1 RC right now, then 4.1 will get its own branch. After that, commits to master will go into 4.2. So this will be in 4.2.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Kingwl

Wenlu Wang (Kingwl) commented Oct 29, 2020

Copy link
Copy Markdown
Contributor Author

TypeScript Bot (@typescript-bot) pack this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Heya Wenlu Wang (@Kingwl), I've started to run the tarball bundle task on this PR at 9fad505. You can monitor the build here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@typescript-bot

TypeScript Bot (typescript-bot) commented Oct 29, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Hey Wenlu Wang (@Kingwl), I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/88073/artifacts?artifactName=tgz&fileId=1062C274A86E3AACC8BC8EC93C079C87B60E684E9F8015BD9366FD3BC705D07F02&fileName=/typescript-4.1.0-insiders.20201029.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sandersn
Merge branch 'master' into pedanticPropertyLookup
d932685
@typescript-bot

TypeScript Bot (typescript-bot) commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

The TypeScript team hasn't accepted the linked issue #40170. This makes it less likely that we'll review or accept this PR. Try to get the originating issue accepted.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sandersn
Nathan Shively-Sanders (sandersn) merged commit ce8d702 into microsoft:master Nov 2, 2020
@Kingwl
Wenlu Wang (Kingwl) deleted the pedanticPropertyLookup branch November 3, 2020 03:22
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Nov 21, 2020
TypeScript 4.2 Iteration Plan #41601
Closed
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Dec 2, 2020
Dogfood the 'noPropertyAccessFromIndexSignature' flag #41784
Closed
@concavelenz John Lenz (concavelenz) mentioned this pull request Oct 29, 2021
noPropertyAccessFromIndexSignature does not affect object literals #46435
Open
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@andrewbranch Andrew Branch (andrewbranch) andrewbranch approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandersn Nathan Shively-Sanders (sandersn)

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pedanticPropertyLookup

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Kingwl @sandersn @ssledorze @typescript-bot @andrewbranch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.