GeezerVison is showing github.com — Fix class expression from being assignable if types don't match by tiagovtristao · Pull Request #40660 · microsoft/TypeScript
Conversation
This PR aims to fix #39469
A simpler code version highlighting the problem is seen below:
interface A {
prop: string;
}
const A: {new(): A} = class {}
The const A declaration should be invalid since the initializer doesn't have the prop property.
Currently, the initializer is having members of the A symbol merged into it, which is invalid in this scenario. This is however the behaviour that it is expected for const declarations where the initializer is function-like, as seen in #26368.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
zlianon and karol-majewski reacted with thumbs up emoji
|
All CLA requirements met.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just moved getDeclarationOfExpando to getSymbolOfExpando in checker.ts. You'll need to make this change there.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tiagovtristao reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.