GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Add at method by Kingwl · Pull Request #40697 · microsoft/TypeScript Conversation
Contributor
Fixes #40695
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Nathan Shively-Sanders (sandersn)
requested a review
from Ron Buckton (rbuckton)
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's painful when you edit something on a very very very long line.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should convert these into baseline/snapshot tests. Not necessary for you to do in this PR, so I've filed #44950 to keep track of the issue.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should I revert these changes?...
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Co-authored-by: Anonymous <[email protected]>
Ron Buckton (rbuckton)
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assuming there are no further web compatibility issues with
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should convert these into baseline/snapshot tests. Not necessary for you to do in this PR, so I've filed #44950 to keep track of the issue.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Ron Buckton (rbuckton)
suggested changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That was supposed to be a request changes, sorry.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Felipe Plets (felipeplets)
approved these changes
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
There was an error while loading. Please reload this page.
|
We discussed this in the design meeting and concluded:
declare let t: [string, number] let n = t.at(-1) // n: number type TN = (typeof t)[-1] // also number? // and perhaps even declare let t2: [...string, number] let n2 = t.at(-1) Though the second example would require adding quite a bit more code to the checker. I expect Daniel Rosenwasser (@DanielRosenwasser) will link the notes when he's done preparing them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ron Buckton (@rbuckton) Can you take another look and merge if all your comments have been addressed? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It looks like a different PR was merged that already addressed this: #46291 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Add support of Item method (stage 3)
There was an error while loading. Please reload this page.