GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — preserve this when extracting functions by Zzzen · Pull Request #41992 · microsoft/TypeScript

Conversation

@Zzzen

@Zzzen Zzzen (Zzzen) commented Dec 16, 2020

Copy link
Copy Markdown
Contributor

Fixes #39931

Previously, this is assumed to be a reference to class. Now we can detect whether this is referring to a class or function. in the latter case, we need to pass this to the new function.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zzzen
preserve this when extracting functions
119c2aa
@typescript-bot TypeScript Bot (typescript-bot) added the For Backlog Bug PRs that fix a backlog bug label Dec 16, 2020
@sandersn Nathan Shively-Sanders (sandersn) assigned Jesse Trinity (jessetrinity) Jan 12, 2021
sandersn
Nathan Shively-Sanders (sandersn) requested changes Jan 12, 2021
View reviewed changes

@sandersn Nathan Shively-Sanders (sandersn) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestion about naming enum member

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/services/refactors/extractSymbol.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Zzzen
rename IsThisReferringToFunction to UsesThisInFunction
7ac213a
@sandersn
Nathan Shively-Sanders (sandersn) requested a review from Jake Bailey (jakebailey) February 24, 2022 21:47
@sandersn Nathan Shively-Sanders (sandersn) assigned Jake Bailey (jakebailey) and unassigned Jesse Trinity (jessetrinity) Feb 24, 2022
jakebailey
Jake Bailey (jakebailey) reviewed Mar 4, 2022
View reviewed changes
Comment thread src/services/refactors/extractSymbol.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@sandersn

Nathan Shively-Sanders (sandersn) commented Mar 31, 2022

Copy link
Copy Markdown
Member

Do you want to keep working on this? Otherwise I'd like to close it to reduce the number of open PRs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Zzzen (Zzzen) added 3 commits April 4, 2022 16:43
@Zzzen
Merge branch 'microsoft:main' into extract-symbol-this
0e954e5
@Zzzen
refactor
68623bc
@Zzzen
Merge remote-tracking branch 'mine/extract-symbol-this' into extract-…
9408d18 
…symbol-this
@Zzzen

Zzzen (Zzzen) commented Apr 4, 2022

Copy link
Copy Markdown
Contributor Author

Yes, I will keep working on this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Zzzen
update tests
5502a24
@Zzzen
Zzzen (Zzzen) force-pushed the extract-symbol-this branch from 0b0a5bf to 5502a24 Compare April 4, 2022 13:14
jakebailey
Jake Bailey (jakebailey) approved these changes Apr 4, 2022
View reviewed changes

@jakebailey Jake Bailey (jakebailey) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, no pun intended.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sandersn
Nathan Shively-Sanders (sandersn) approved these changes Apr 7, 2022
View reviewed changes
@sandersn
Nathan Shively-Sanders (sandersn) merged commit f4b99ea into microsoft:main Apr 7, 2022
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn Nathan Shively-Sanders (sandersn) sandersn approved these changes
@jakebailey Jake Bailey (jakebailey) jakebailey approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@jakebailey Jake Bailey (jakebailey)

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

this is not preserved when extracted to function in module scope

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Zzzen @sandersn @jakebailey @typescript-bot @jessetrinity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.