GeezerVison is showing github.com — Template literal types for contextually typed template literal expressions by ahejlsberg · Pull Request #43376 · microsoft/TypeScript
Conversation
In #41891 we introduced template literal types for all template literal expressions. That turned out to be too much of a breaking change, and it was reverted in #42588. In this PR we instead introduce template literal types for contextually typed template literal expressions. Specifically, a template literal expression is given a template literal type if it is contextually typed by a string literal or template literal type, or if it is contextually typed by a generic type with a constraint that is assignable to type string, alleviating the need to use as const in scenarios where it is obvious a template literal type is desired. This less aggressive approach fixes the originally reported issues and shouldn't cause any backwards compatibility breaks.
Some examples:
function bar(s: string): `hello ${string}` {
return `hello ${s}`; // Now ok, previously was error
}
declare let s: string;
declare function g1<T>(x: T): T;
declare function g2<T extends string>(x: T): T;
let x1 = g1(`xyz-${s}`); // string
let x2 = g2(`xyz-${s}`); // `xyz-${string}`, previously was string
Fixes #43143.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
DanielRosenwasser, KisaragiEffective, ExE-Boss, dragomirtitian, sinclairzx81, Mahmoud-Masri, WillAvudim, c69-addepar, and bcakmakoglu reacted with thumbs up emoji
uhyo, sinclairzx81, aminpaks, sergeks, WillAvudim, and sstur reacted with hooray emoji
earthlyreason, millsp, sinclairzx81, aminpaks, WillAvudim, and c69-addepar reacted with heart emoji
All reactions
-
👍
9 reactions
-
🎉
6 reactions
-
❤️
6 reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|