GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow `override` as parameter property by andrewbranch · Pull Request #43831 · microsoft/TypeScript

Conversation

@andrewbranch

@andrewbranch Andrew Branch (andrewbranch) commented Apr 26, 2021

Copy link
Copy Markdown
Member

#39669 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andrewbranch
Allow override as parameter property
b435e1c
@typescript-bot TypeScript Bot (typescript-bot) assigned Andrew Branch (andrewbranch) Apr 26, 2021
@typescript-bot TypeScript Bot (typescript-bot) added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Apr 26, 2021
@andrewbranch
Andrew Branch (andrewbranch) requested a review from Daniel Rosenwasser (DanielRosenwasser) April 26, 2021 17:58
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes Apr 26, 2021
View reviewed changes
@andrewbranch
Update other baseline
97ee23a
ajafff
Klaus Meinhardt (ajafff) reviewed Apr 26, 2021
View reviewed changes
Comment thread src/compiler/checker.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) requested changes Apr 26, 2021
View reviewed changes

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same sort of comment that's around the readonly modifier, then update checkGrammarModifiers

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andrew Branch (andrewbranch) added 4 commits April 26, 2021 15:51
@andrewbranch
Add test for override on normal parameter
38700c9
@andrewbranch
Copy typo fix
0b4e464
@andrewbranch
Update baselines
c5ee125
@andrewbranch
Update API baseline
e058849
sheetalkamat
Sheetal Nandi (sheetalkamat) approved these changes Apr 27, 2021
View reviewed changes
@Kingwl

Wenlu Wang (Kingwl) commented Apr 28, 2021

Copy link
Copy Markdown
Contributor

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) mentioned this pull request Apr 28, 2021
Design Meeting Notes, 4/28/2021 #43871
Closed
@andrewbranch
Andrew Branch (andrewbranch) merged commit 791c747 into microsoft:master Apr 28, 2021
@andrewbranch
Andrew Branch (andrewbranch) deleted the feature/override-parameter-property branch April 28, 2021 23:41
This was referenced May 9, 2021
feat(es/parser/typescript): allow override as parameter property swc-project/swc#1667
Merged
feat: allow override as parameter property evanw/esbuild#1262
Merged
This was referenced Jun 6, 2021
fix(typescript-estree): support override modifier for parameter property typescript-eslint/typescript-eslint#3485
Merged
[Bug]: Syntax error is thrown for override modifiers for parameter properties babel/babel#13427
Closed
@microsoft Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) DanielRosenwasser requested changes
@sheetalkamat Sheetal Nandi (sheetalkamat) sheetalkamat approved these changes
+1 more reviewer
@ajafff Klaus Meinhardt (ajafff) ajafff left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@andrewbranch Andrew Branch (andrewbranch)

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@andrewbranch @Kingwl @DanielRosenwasser @sheetalkamat @ajafff @typescript-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.